Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C3: Refactor dns polling to improve experience for WARP users #3729

Merged
merged 4 commits into from
Aug 10, 2023

Conversation

jculvey
Copy link
Contributor

@jculvey jculvey commented Aug 9, 2023

What this PR solves / how to test:

This gives WARP users a smoother experience by doing a more custom lookup of DNS that avoid potential caching issues.

Associated docs issue(s)/PR(s):

  • [insert associated docs issue(s)/PR(s)]

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@jculvey jculvey requested review from a team as code owners August 9, 2023 22:17
@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2023

🦋 Changeset detected

Latest commit: de8af8e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5825276025/npm-package-wrangler-3729

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5825276025/npm-package-wrangler-3729

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5825276025/npm-package-wrangler-3729 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5825276025/npm-package-cloudflare-pages-shared-3729

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #3729 (2ea5f12) into main (94fed9d) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3729      +/-   ##
==========================================
+ Coverage   75.17%   75.21%   +0.04%     
==========================================
  Files         194      194              
  Lines       11410    11410              
  Branches     3013     3013              
==========================================
+ Hits         8577     8582       +5     
+ Misses       2833     2828       -5     

see 3 files with indirect coverage changes

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like what you did with the dns2 library here, James. At the high level the change looks good. Could you please review the minor suggestions mostly related to readability and documentation? Thanks

packages/create-cloudflare/src/helpers/poll.ts Outdated Show resolved Hide resolved
packages/create-cloudflare/src/helpers/poll.ts Outdated Show resolved Hide resolved
.changeset/hip-lobsters-sniff.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@jculvey jculvey changed the title C3: Refactor dns resolution to work better with WARP C3: Refactor dns polling to improve experience for WARP users Aug 10, 2023
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for all the improvements.

@IgorMinar
Copy link
Contributor

oops.. just noticed that the test is failing.. due to a flake? please take a look

@jculvey
Copy link
Contributor Author

jculvey commented Aug 10, 2023

oops.. just noticed that the test is failing.. due to a flake? please take a look

Yep, dealing with some flakiness, working through it now.

@jculvey jculvey merged commit 9d8509e into main Aug 10, 2023
13 checks passed
@jculvey jculvey deleted the c3-dns-refactor branch August 10, 2023 20:56
@github-actions github-actions bot mentioned this pull request Aug 10, 2023
lrapoport-cf pushed a commit that referenced this pull request Aug 11, 2023
* C3: Refactor dns resolution to improve reliability of DNS polling in summary step
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants