-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C3: Refactor dns polling to improve experience for WARP users #3729
Conversation
🦋 Changeset detectedLatest commit: de8af8e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5825276025/npm-package-wrangler-3729 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5825276025/npm-package-wrangler-3729 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5825276025/npm-package-wrangler-3729 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5825276025/npm-package-cloudflare-pages-shared-3729 Note that these links will no longer work once the GitHub Actions artifact expires. |
Codecov Report
@@ Coverage Diff @@
## main #3729 +/- ##
==========================================
+ Coverage 75.17% 75.21% +0.04%
==========================================
Files 194 194
Lines 11410 11410
Branches 3013 3013
==========================================
+ Hits 8577 8582 +5
+ Misses 2833 2828 -5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like what you did with the dns2 library here, James. At the high level the change looks good. Could you please review the minor suggestions mostly related to readability and documentation? Thanks
cb40272
to
6cf281b
Compare
de8af8e
to
2ea5f12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for all the improvements.
oops.. just noticed that the test is failing.. due to a flake? please take a look |
Yep, dealing with some flakiness, working through it now. |
* C3: Refactor dns resolution to improve reliability of DNS polling in summary step
What this PR solves / how to test:
This gives WARP users a smoother experience by doing a more custom lookup of DNS that avoid potential caching issues.
Associated docs issue(s)/PR(s):
Author has included the following, where applicable:
Reviewer is to perform the following, as applicable:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.