-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wrangler] Update the commands list #3735
Conversation
🦋 Changeset detectedLatest commit: a61500f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
553401c
to
88d9ce9
Compare
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9601015901/npm-package-wrangler-3735 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3735/npm-package-wrangler-3735 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9601015901/npm-package-wrangler-3735 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9601015901/npm-package-create-cloudflare-3735 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9601015901/npm-package-cloudflare-kv-asset-handler-3735 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9601015901/npm-package-miniflare-3735 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9601015901/npm-package-cloudflare-pages-shared-3735 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9601015901/npm-package-cloudflare-vitest-pool-workers-3735 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
bc46957
to
1d5b6e0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3735 +/- ##
==========================================
+ Coverage 72.44% 75.44% +2.99%
==========================================
Files 331 223 -108
Lines 17298 12332 -4966
Branches 4422 3188 -1234
==========================================
- Hits 12532 9304 -3228
+ Misses 4766 3028 -1738
|
fd41704
to
30ff496
Compare
30ff496
to
00c640f
Compare
Great effort combing through all of this! A couple subjective points:
|
@RamIdeas thanks for the feedback! the emoji changes are based on a proposal from the design team -- i'll get them looped into the discussion. for my two cents, i agree that the consistency has a lower fun quotient 😄, but i do think it adds some informational value that the more assorted collection lacks: it signals that there is a loose relationship between the items in the different emoji groups, and also distracts less from the command descriptions. |
cc @Meahaa |
Excellent points let's:
|
I think you're referring to the "open beta" text in the figma design doc which I think being on-brand orange is great! I was referring to the ⚑ flag emoji which blends into the text a little – a non-exhaustive set of alternatives to consider:
|
@Meahaa - can you take a look at @RamIdeas' last comment? Should we update that last emoji? |
ooh I like the test tube let's go with that! |
00c640f
to
b776baf
Compare
@Meahaa I am taking over this PR to cross it over the finish line. Can you please clarify point 2 for me? Do we keep the current emojis as they are, or do we change them as per design? |
b776baf
to
45f2f5d
Compare
@Meahaa @RamIdeas @petebacondarwin I've added a before and after screenshot to the description of this PR. Before reviewing the code, is there consensus that, visually, things are as we want them to be? <3 |
I read that @Meahaa wrote:
So I think that means we are all agreed that we should not switch out the mix of emojis for the boring few? |
Yup! Let's just keep the current emojis for now! Agree with the fact that they make them more fun for now and we can always update to make them even better later! |
fefdde5
to
902ec93
Compare
@@ -18,13 +18,13 @@ export default function registerVersionsDeploymentsSubcommands( | |||
versionDeploymentsYargs | |||
.command( | |||
"list", | |||
"Displays the 10 most recent deployments of your Worker [beta]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing, as the beta
nature of these commands is signalled at command level, which should be enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc// @RamIdeas
@@ -204,33 +210,34 @@ export function createCLIParser(argv: string[]) { | |||
}) | |||
.scriptName("wrangler") | |||
.wrap(null) | |||
.locale("en_US") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forcing locale here, since we don't support anything other than en
. This also ensures we don't run into any unexpected behaviour when we call wrangler.updateStrings()
further down
902ec93
to
9c517a4
Compare
9c517a4
to
8bd2bc7
Compare
This commit cleans up and standardizes the look and of all `wrangler` commands as displayed by `wrangler --help` and `wrangler <cmd> --help`.
8bd2bc7
to
a61500f
Compare
Fixes a regression accidentally introduced by #3735.
* fix: the docs command should not crash if given search terms Fixes a regression accidentally introduced by #3735. * fixup! fix: the docs command should not crash if given search terms * Rename `command` positional to `search` to make it clearer what it is used for * fixup! fix: the docs command should not crash if given search terms
What this PR solves / how to test:
This PR cleans up and standardises the look and feel of all
wrangler
commands as displayed bywrangler --help
andwrangler <cmd> --help
.Please refer to original designs here
Before
After
Here is the list of all public facing wrangler commands, in their updated version:
**wrangler deployments --help**
**wrangler deployments --x-versions --help**
**npx wrangler rollback --help**
**npx wrangler rollback --x-versions --help**
**npx wrangler versions --x-versions --help**
**wrangler triggers --x-versions --help**
**wrangler kv --help**
**wrangler queues --help**
**wrangler r2 --help**
**wrangler d1 --help**
**wrangler vectorize --help**
**wrangler hyperdrive --help**
**wrangler pages --help**
**wrangler mtls-certificate --help**
**wrangler cloudchamber --help**
**wrangler pubsub --help**
**wrangler dispatch-namespace --help**
**wrangler ai --help**
**wrangler login --help**
Author has addressed the following