Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Retry deployment errors in wrangler pages publish #3758

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

jahands
Copy link
Contributor

@jahands jahands commented Aug 14, 2023

Occasionally, creating a deployment can fail due to internal errors in the POST /deployments API call. Rather than failing the deployment, this will retry first.

Fixes PAGES-2935

What this PR solves / how to test:
The /deployments endpoint occasionally returns a 5XX error, causing a deployment to fail. This will improve reliability of the wrangler pages publish command.

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

Occasionally, creating a deployment can fail due to internal errors in
the POST /deployments API call. Rather than failing the deployment, this
will retry first.
@jahands jahands requested review from a team as code owners August 14, 2023 21:41
@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2023

🦋 Changeset detected

Latest commit: bdf5f95

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5860954498/npm-package-wrangler-3758

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5860954498/npm-package-wrangler-3758

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5860954498/npm-package-wrangler-3758 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5860954498/npm-package-cloudflare-pages-shared-3758

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #3758 (bdf5f95) into main (80c1b38) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3758      +/-   ##
==========================================
- Coverage   75.17%   75.17%   -0.01%     
==========================================
  Files         194      194              
  Lines       11410    11426      +16     
  Branches     3013     3017       +4     
==========================================
+ Hits         8577     8589      +12     
- Misses       2833     2837       +4     
Files Changed Coverage Δ
packages/wrangler/src/api/pages/deploy.tsx 86.25% <76.47%> (-1.68%) ⬇️
packages/wrangler/src/pages/constants.ts 100.00% <100.00%> (ø)

@CarmenPopoviciu CarmenPopoviciu merged commit 0adccc7 into main Aug 22, 2023
12 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the jhands/retry-pages-deploy branch August 22, 2023 10:52
@github-actions github-actions bot mentioned this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants