-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wrangler] R2 jurisdictions support #3775
Conversation
🦋 Changeset detectedLatest commit: 7a158ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6164470821/npm-package-wrangler-3775 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6164470821/npm-package-wrangler-3775 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6164470821/npm-package-wrangler-3775 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6164470821/npm-package-cloudflare-pages-shared-3775 Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
Codecov Report
@@ Coverage Diff @@
## main #3775 +/- ##
==========================================
+ Coverage 75.10% 75.12% +0.02%
==========================================
Files 195 195
Lines 11487 11526 +39
Branches 3036 3049 +13
==========================================
+ Hits 8627 8659 +32
- Misses 2860 2867 +7
|
a8ae95f
to
e6d5480
Compare
Hey! 👋 This looks good to me, though I'm not sure what's up with the Windows tests. 😕 I'll try re-run them, but have you got a Windows laptop to try run them locally? |
fc6227d
to
aa1371b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! One small nit, but that's it
-v, --version Show version number [boolean] | ||
|
||
Options: | ||
-J, --jurisdiction The jurisdiction where the new bucket will be created [string]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't generally use capitalised flags in Wrangler. For consistency, would it be possible to use -j
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-j seems to be in use already for --experimental-json-config. Would it be better to use -n?
Could you rebase on |
a4c08fd
to
6aca204
Compare
The windows tests seem to have failed again after rebase. I don't have a windows machine to test on, but last time this happened it resolved after running again. |
6aca204
to
7a158ce
Compare
Fixes # R2-1740
What this PR solves / how to test:
This PR adds two things:
Associated docs issue(s)/PR(s):
None
Author has included the following, where applicable:
Reviewer is to perform the following, as applicable:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.