Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wrangler] Fix typo (persistance -> persistence) #3790

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

Exaphis
Copy link
Contributor

@Exaphis Exaphis commented Aug 21, 2023

What this PR solves / how to test:

Fixes a typo in the following commands:

  • wrangler r2 object {put,get,delete} --help
  • wrangler kv:key {put,list,get,delete} --help
  • wrangler kv:bulk {put,delete} --help

Associated docs issue(s)/PR(s):

None

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@Exaphis Exaphis requested a review from a team as a code owner August 21, 2023 00:03
@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2023

⚠️ No Changeset found

Latest commit: 36aa50c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Exaphis Exaphis changed the title Fix typo (persistance -> persistence) [wrangler] Fix typo (persistance -> persistence) Aug 21, 2023
Copy link
Member

@GregBrimble GregBrimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #3790 (36aa50c) into main (3bba1eb) will increase coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3790      +/-   ##
==========================================
+ Coverage   75.17%   75.20%   +0.03%     
==========================================
  Files         194      194              
  Lines       11410    11410              
  Branches     3013     3013              
==========================================
+ Hits         8577     8581       +4     
+ Misses       2833     2829       -4     
Files Changed Coverage Δ
packages/wrangler/src/kv/index.ts 100.00% <ø> (ø)
packages/wrangler/src/r2/index.ts 87.30% <ø> (ø)

... and 3 files with indirect coverage changes

@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5920328957/npm-package-wrangler-3790

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5920328957/npm-package-wrangler-3790

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5920328957/npm-package-wrangler-3790 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5920328957/npm-package-cloudflare-pages-shared-3790

Note that these links will no longer work once the GitHub Actions artifact expires.

@lrapoport-cf lrapoport-cf merged commit 94f1580 into cloudflare:main Aug 21, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants