-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wrangler] Fix lint issues #3821
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5956450275/npm-package-wrangler-3821 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5956450275/npm-package-wrangler-3821 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5956450275/npm-package-wrangler-3821 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5956450275/npm-package-cloudflare-pages-shared-3821 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov Report
@@ Coverage Diff @@
## main #3821 +/- ##
==========================================
+ Coverage 75.25% 75.29% +0.04%
==========================================
Files 195 195
Lines 11459 11450 -9
Branches 3025 3020 -5
==========================================
- Hits 8623 8621 -2
+ Misses 2836 2829 -7
|
Thanks for fixing these! @IgorMinar and I were just talking about this, and given we feel this stuff is important enough to warn about, it's important enough to block on and force developers to address the issue. We ought to change our eslint config from raising warnings to raising errors. |
0fe2027
to
7e1fd42
Compare
7e1fd42
to
c77a2ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @jculvey
What this PR solves / how to test:
Fixes a number of lint issues that are popping up with annotations on every PR to workers-sdk.
Reviewer is to perform the following, as applicable:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.