Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wrangler] Fix lint issues #3821

Merged
merged 2 commits into from
Aug 24, 2023
Merged

[wrangler] Fix lint issues #3821

merged 2 commits into from
Aug 24, 2023

Conversation

jculvey
Copy link
Contributor

@jculvey jculvey commented Aug 23, 2023

What this PR solves / how to test:

Fixes a number of lint issues that are popping up with annotations on every PR to workers-sdk.

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@jculvey jculvey requested review from a team as code owners August 23, 2023 19:26
@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2023

⚠️ No Changeset found

Latest commit: c77a2ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jculvey jculvey changed the title Fix a number of lint issues in wrangler [wrangler] Fix lint issues Aug 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5956450275/npm-package-wrangler-3821

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5956450275/npm-package-wrangler-3821

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5956450275/npm-package-wrangler-3821 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5956450275/npm-package-cloudflare-pages-shared-3821

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.5.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare 3.20230814.1 3.20230814.1
workerd 1.20230814.1 1.20230814.1

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #3821 (c77a2ab) into main (a8d8d9a) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3821      +/-   ##
==========================================
+ Coverage   75.25%   75.29%   +0.04%     
==========================================
  Files         195      195              
  Lines       11459    11450       -9     
  Branches     3025     3020       -5     
==========================================
- Hits         8623     8621       -2     
+ Misses       2836     2829       -7     
Files Changed Coverage Δ
packages/wrangler/src/pages/build.ts 69.04% <ø> (+2.38%) ⬆️
packages/wrangler/src/pages/buildFunctions.ts 90.24% <ø> (ø)
...ckages/wrangler/src/pages/functions/buildWorker.ts 70.65% <ø> (ø)
packages/wrangler/src/api/pages/deploy.tsx 86.15% <100.00%> (-0.32%) ⬇️
packages/wrangler/src/pages/upload.tsx 78.94% <100.00%> (ø)

... and 2 files with indirect coverage changes

@1000hz
Copy link
Contributor

1000hz commented Aug 23, 2023

Thanks for fixing these! @IgorMinar and I were just talking about this, and given we feel this stuff is important enough to warn about, it's important enough to block on and force developers to address the issue. We ought to change our eslint config from raising warnings to raising errors.

@jculvey jculvey force-pushed the jculvey/fix-wrangler-lint-issues branch from 0fe2027 to 7e1fd42 Compare August 23, 2023 20:45
@jculvey jculvey force-pushed the jculvey/fix-wrangler-lint-issues branch from 7e1fd42 to c77a2ab Compare August 23, 2023 21:04
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jculvey

@jculvey jculvey merged commit 6b6788d into main Aug 24, 2023
12 checks passed
@jculvey jculvey deleted the jculvey/fix-wrangler-lint-issues branch August 24, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants