Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore cached account id when CLOUDFLARE_ACCOUNT_ID is specified #3912

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

jspspike
Copy link
Contributor

@jspspike jspspike commented Sep 7, 2023

Fixes #1590

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@jspspike jspspike requested a review from a team as a code owner September 7, 2023 20:15
@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2023

🦋 Changeset detected

Latest commit: 098150b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6114357304/npm-package-wrangler-3912

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6114357304/npm-package-wrangler-3912

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6114357304/npm-package-wrangler-3912 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6114357304/npm-package-cloudflare-pages-shared-3912

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.7.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare 3.20230904.0 3.20230904.0
workerd 1.20230904.0 1.20230904.0
workerd --version 1.20230904.0 2023-09-04

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #3912 (098150b) into main (a986f19) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3912      +/-   ##
==========================================
+ Coverage   75.10%   75.12%   +0.02%     
==========================================
  Files         195      195              
  Lines       11487    11487              
  Branches     3036     3036              
==========================================
+ Hits         8627     8630       +3     
+ Misses       2860     2857       -3     
Files Changed Coverage Δ
packages/wrangler/src/user/user.ts 72.23% <100.00%> (ø)

... and 2 files with indirect coverage changes

📢 Have feedback on the report? Share it here.

@jspspike jspspike merged commit 0ba5884 into main Sep 11, 2023
@jspspike jspspike deleted the jspspike/cached-accountid branch September 11, 2023 15:10
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Wrangler not honouring CLOUDFLARE_ACCOUNT_ID environment variable when cached config is here
2 participants