Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update wrangler pages dev D1 and DO descriptions #3954

Merged
merged 6 commits into from
Sep 18, 2023

Conversation

dario-piotrowicz
Copy link
Member

Currently wrangler pages dev --help doesn't provide useful/correct information on how to add a DO binding, I think that the yargs description update simply got missed in #1641

@dario-piotrowicz dario-piotrowicz requested review from a team as code owners September 15, 2023 12:10
@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2023

🦋 Changeset detected

Latest commit: f87a459

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dario-piotrowicz dario-piotrowicz changed the title update pages dev do description update pages dev do description Sep 15, 2023
@dario-piotrowicz dario-piotrowicz changed the title update pages dev do description update pages dev DO yargs description Sep 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6198521049/npm-package-wrangler-3954

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6198521049/npm-package-wrangler-3954

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6198521049/npm-package-wrangler-3954 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6198521049/npm-package-cloudflare-pages-shared-3954

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.8.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare 3.20230904.0 3.20230904.0
workerd 1.20230904.0 1.20230904.0
workerd --version 1.20230904.0 2023-09-04

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #3954 (f87a459) into main (702409a) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3954      +/-   ##
==========================================
+ Coverage   75.08%   75.12%   +0.04%     
==========================================
  Files         195      195              
  Lines       11526    11526              
  Branches     3049     3049              
==========================================
+ Hits         8654     8659       +5     
+ Misses       2872     2867       -5     
Files Changed Coverage Δ
packages/wrangler/src/pages/dev.ts 16.22% <ø> (ø)

... and 3 files with indirect coverage changes

@dario-piotrowicz dario-piotrowicz changed the title update pages dev DO yargs description update wrangler pages dev D1 and DO descriptions Sep 15, 2023
@dario-piotrowicz dario-piotrowicz merged commit bc88f0e into main Sep 18, 2023
@dario-piotrowicz dario-piotrowicz deleted the pages-dev-do-help branch September 18, 2023 08:33
@github-actions github-actions bot mentioned this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants