-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrangler: Add AI binding #3992
wrangler: Add AI binding #3992
Conversation
🦋 Changeset detectedLatest commit: dbefb3d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6259570855/npm-package-wrangler-3992 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6259570855/npm-package-wrangler-3992 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6259570855/npm-package-wrangler-3992 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6259570855/npm-package-cloudflare-pages-shared-3992 Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
Codecov Report
@@ Coverage Diff @@
## main #3992 +/- ##
==========================================
+ Coverage 74.85% 74.89% +0.04%
==========================================
Files 196 196
Lines 11604 11624 +20
Branches 3044 3051 +7
==========================================
+ Hits 8686 8706 +20
Misses 2918 2918
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! It would be great to see some more tests in packages/wrangler/e2e/deploy.test.ts
(similar to the queues tests in that file) to verify that the binding is being passed through and uploaded properly
Added binding for the AI project.
Added missing test @penalosa . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! The additional tests are super helpful as well, thank you 😄
LGTM! It would be nice to see an example Wrangler TOML file and some more explanation of how to use this in the changeset file, but non-blocking given the timeline |
Added examples to changeset. |
Can this be merged? I don't have write permissions to this repo. Thanks. |
* wrangler: Add AI binding Added binding for the AI project. * Workers AI: added example
Added binding for the AI project.
Author has included the following, where applicable:
Reviewer is to perform the following, as applicable: