-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrangler: Implement hyperdrive command #3999
wrangler: Implement hyperdrive command #3999
Conversation
🦋 Changeset detectedLatest commit: 2f209a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6315042400/npm-package-wrangler-3999 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6315042400/npm-package-wrangler-3999 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6315042400/npm-package-wrangler-3999 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6315042400/npm-package-cloudflare-pages-shared-3999 Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
71f6231
to
c6be27f
Compare
Codecov Report
@@ Coverage Diff @@
## main #3999 +/- ##
==========================================
+ Coverage 74.96% 74.99% +0.03%
==========================================
Files 207 215 +8
Lines 11832 11987 +155
Branches 3081 3111 +30
==========================================
+ Hits 8870 8990 +120
- Misses 2962 2997 +35
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests and commands look good. Didn't scrutinize the hyperdrive specific logic too closely but the tests make sense and wrangler changes look good
c6965b3
to
29fcf2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the testing not covering the new bindings validation, in config validation.ts it looks good to me.
Needs a rebase but LGTM EDIT: I'm doing the rebase now |
56268bd
to
c8fc636
Compare
c8fc636
to
9402fbb
Compare
What this PR solves / how to test:
Adds support for hyperdrive.
Author has included the following, where applicable:
Reviewer is to perform the following, as applicable: