Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[D1] clean-up validation and epilogue #4006

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Conversation

rozenmd
Copy link
Contributor

@rozenmd rozenmd commented Sep 21, 2023

No description provided.

@rozenmd rozenmd requested a review from elithrar September 21, 2023 18:52
@rozenmd rozenmd requested review from a team as code owners September 21, 2023 18:52
@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2023

🦋 Changeset detected

Latest commit: 80eaf95

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6266124837/npm-package-wrangler-4006

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6266124837/npm-package-wrangler-4006

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6266124837/npm-package-wrangler-4006 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6266124837/npm-package-cloudflare-pages-shared-4006

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.9.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare 3.20230918.0 3.20230918.0
workerd 1.20230904.0 1.20230904.0
workerd --version 1.20230904.0 2023-09-04

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #4006 (80eaf95) into main (3556474) will increase coverage by 0.07%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4006      +/-   ##
==========================================
+ Coverage   74.89%   74.97%   +0.07%     
==========================================
  Files         196      196              
  Lines       11624    11611      -13     
  Branches     3051     3050       -1     
==========================================
- Hits         8706     8705       -1     
+ Misses       2918     2906      -12     
Files Changed Coverage Δ
packages/wrangler/src/config/validation.ts 90.22% <ø> (-0.03%) ⬇️
packages/wrangler/src/d1/create.tsx 35.71% <ø> (+1.23%) ⬆️
packages/wrangler/src/d1/delete.ts 36.36% <ø> (+1.58%) ⬆️
packages/wrangler/src/d1/list.tsx 33.33% <ø> (+1.07%) ⬆️
packages/wrangler/src/d1/backups.tsx 30.66% <100.00%> (+1.55%) ⬆️
packages/wrangler/src/d1/execute.tsx 57.24% <100.00%> (-0.31%) ⬇️
packages/wrangler/src/d1/migrations/apply.tsx 59.34% <100.00%> (+1.73%) ⬆️
packages/wrangler/src/d1/migrations/create.tsx 93.54% <100.00%> (-0.21%) ⬇️
packages/wrangler/src/d1/migrations/list.tsx 68.57% <100.00%> (-0.88%) ⬇️
packages/wrangler/src/d1/utils.ts 78.57% <100.00%> (ø)

... and 2 files with indirect coverage changes

@@ -0,0 +1,5 @@
---
"wrangler": patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alpha -> beta feels like a minor to me, but non-blocking

@rozenmd rozenmd merged commit bc8c147 into main Sep 21, 2023
@rozenmd rozenmd deleted the rozenmd/d1-alpha-cleanup branch September 21, 2023 19:53
elithrar pushed a commit that referenced this pull request Sep 21, 2023
* teach wrangler about d1 beta

* Create lazy-clocks-exist.md

* don't log a warning for every command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants