-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrangler: some additions #4013
wrangler: some additions #4013
Conversation
🦋 Changeset detectedLatest commit: 4692d92 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I've removed the 'bad' mTLS test, which a) had the wrong snapshot and b) shouldn't force other commands to update the mTLS test when they add a new top-level command. |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6302953085/npm-package-wrangler-4013 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6302953085/npm-package-wrangler-4013 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6302953085/npm-package-wrangler-4013 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6302953085/npm-package-cloudflare-pages-shared-4013 Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
ea00059
to
a5db98b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comment around renaming from indexes
-> indices
, but other than that this is looking pretty good! Couple merge issues, and it looks like some bits are still WIP, but no major issues at this stage.
Co-authored-by: Somhairle MacLeòid <smacleod@cloudflare.com>
@penalosa this should be OK to merge from my perspective, pending any final review. Both |
a0bf37b
to
865619a
Compare
Codecov Report
@@ Coverage Diff @@
## main #4013 +/- ##
==========================================
- Coverage 75.01% 74.98% -0.03%
==========================================
Files 200 207 +7
Lines 11665 11826 +161
Branches 3058 3079 +21
==========================================
+ Hits 8750 8868 +118
- Misses 2915 2958 +43
|
Waiting on final review & merge. |
We’re going to stick with “indexes”, since this is convention in this use-case and not incorrect (e.g. database indexes, not indices). |
@elithrar Mostly looking good, but it would be great to see some tests of the added Wrangler functionality, including:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran Prettier. Looks good, thanks for adding tests!!
This PR adds:
wrangler vectorize
[[vectorize]]
bindingAuthor has included the following, where applicable: