Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Default local dev server to *" #4014

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

irvinebroque
Copy link
Contributor

Reverts #3733

@irvinebroque irvinebroque requested a review from a team as a code owner September 22, 2023 16:51
@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2023

⚠️ No Changeset found

Latest commit: f7c94e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6276961746/npm-package-wrangler-4014

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6276961746/npm-package-wrangler-4014

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6276961746/npm-package-wrangler-4014 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6276961746/npm-package-cloudflare-pages-shared-4014

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.9.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare 3.20230918.0 3.20230918.0
workerd 1.20230904.0 1.20230904.0
workerd --version 1.20230904.0 2023-09-04

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #4014 (f7c94e5) into main (00247a8) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4014      +/-   ##
==========================================
+ Coverage   75.01%   75.05%   +0.04%     
==========================================
  Files         200      200              
  Lines       11665    11665              
  Branches     3058     3058              
==========================================
+ Hits         8750     8755       +5     
+ Misses       2915     2910       -5     
Files Changed Coverage Δ
packages/wrangler/src/config/validation.ts 90.22% <100.00%> (ø)

... and 3 files with indirect coverage changes

@lrapoport-cf lrapoport-cf merged commit e93d240 into main Sep 22, 2023
16 checks passed
@lrapoport-cf lrapoport-cf deleted the revert-3733-jspspike/localhost branch September 22, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants