Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[playground] Fix dark mode in Chrome #4036

Merged
merged 1 commit into from
Sep 26, 2023
Merged

[playground] Fix dark mode in Chrome #4036

merged 1 commit into from
Sep 26, 2023

Conversation

penalosa
Copy link
Contributor

What this PR solves / how to test:

  • Chrome uses a dark-mode page for non-html content by default, which was showing as white-on-white

Associated docs issue(s)/PR(s):

  • [insert associated docs issue(s)/PR(s)]

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@penalosa penalosa requested a review from a team as a code owner September 26, 2023 17:36
@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2023

⚠️ No Changeset found

Latest commit: b6fcc04

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6316338662/npm-package-wrangler-4036

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6316338662/npm-package-wrangler-4036

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6316338662/npm-package-wrangler-4036 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6316338662/npm-package-cloudflare-pages-shared-4036

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.10.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare 3.20230922.0 3.20230922.0
workerd 1.20230922.0 1.20230922.0
workerd --version 1.20230922.0 2023-09-22

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa added the preview:workers-playground Trigger a workers playground preview deploy label Sep 26, 2023
@penalosa penalosa merged commit 2eadcee into main Sep 26, 2023
19 checks passed
@penalosa penalosa deleted the penalosa/dark-mode branch September 26, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview:workers-playground Trigger a workers playground preview deploy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants