Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vectorize: fix preset/model property #4041

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

elithrar
Copy link
Contributor

This PR fixes drift between the server and wrangler on the preset field. In the meantime, we will accept both preset and model.

@elithrar elithrar self-assigned this Sep 27, 2023
@elithrar elithrar requested a review from a team as a code owner September 27, 2023 14:12
@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2023

🦋 Changeset detected

Latest commit: f2aa8ec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6327182583/npm-package-wrangler-4041

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6327182583/npm-package-wrangler-4041

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6327182583/npm-package-wrangler-4041 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6327182583/npm-package-cloudflare-pages-shared-4041

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.10.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare 3.20230922.0 3.20230922.0
workerd 1.20230922.0 1.20230922.0
workerd --version 1.20230922.0 2023-09-22

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #4041 (f2aa8ec) into main (2eadcee) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4041   +/-   ##
=======================================
  Coverage   75.02%   75.03%           
=======================================
  Files         216      216           
  Lines       12026    12026           
  Branches     3115     3115           
=======================================
+ Hits         9023     9024    +1     
+ Misses       3003     3002    -1     
Files Coverage Δ
packages/wrangler/src/vectorize/create.tsx 74.07% <0.00%> (ø)

... and 1 file with indirect coverage changes

@elithrar elithrar merged commit 6b1c327 into main Sep 28, 2023
16 checks passed
@elithrar elithrar deleted the silverlock/vectorize/fix-create-preset branch September 28, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants