[wrangler] fix: allow wrangler pages dev sessions to be reloaded
#4054
Conversation
#3951 introduced a change that closed the bootstrapper's IPC channel when Wrangler exited. Whenever `wrangler (pages) dev` reloads, an event is sent on this channel to indicate the dev server is ready. Unfortunately, `wrangler pages dev`'s handler doesn't wait for the dev session to exit before resolving its returned promise, meaning the channel is closed as soon as the dev server is ready, not when Wrangler exits. This means that ready events sent from reloads result in an `ERR_IPC_CHANNEL_CLOSED` that crashes Wrangler. :(
🦋 Changeset detectedLatest commit: 5e99f2f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6341382186/npm-package-wrangler-4054You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6341382186/npm-package-wrangler-4054Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6341382186/npm-package-wrangler-4054 dev path/to/script.jsAdditional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6341382186/npm-package-cloudflare-pages-shared-4054Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
Codecov Report
@@ Coverage Diff @@
## main #4054 +/- ##
==========================================
+ Coverage 75.03% 75.06% +0.02%
==========================================
Files 216 216
Lines 12029 12029
Branches 3116 3116
==========================================
+ Hits 9026 9029 +3
+ Misses 3003 3000 -3
|
Fixes #4008, #4017, remix-run/remix#7510
What this PR solves / how to test:
#3951 introduced a change that closed the bootstrapper's IPC channel when Wrangler exited. Whenever
wrangler (pages) devreloads, an event is sent on this channel to indicate the dev server is ready. Unfortunately,wrangler pages dev's handler didn't wait for the dev session to exit before resolving its returned promise, meaning the channel was closed as soon as the dev server was ready, not when Wrangler exited. This meant that ready events sent from reloads resulted in anERR_IPC_CHANNEL_CLOSEDthat crashed Wrangler. :(This PR updates the code to only resolve the returned promise once the dev session exits, ensuring the channel stays open.
To test, run
npm run devinfixtures/pages-functions-app, wait for the dev server to start, then update a file. Before this change, this would crash. Afterwards, it should reload the dev server with the new script.Associated docs issue(s)/PR(s):
N/A
Author has included the following, where applicable:
Reviewer is to perform the following, as applicable:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr reviewso future reviewers can take inspiration and learn from it.