Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proxy not working with wrangler tail #4149

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

jspspike
Copy link
Contributor

@jspspike jspspike commented Oct 10, 2023

Not sure if there's a better way to go about this without adding a dependency

  • [insert associated docs issue(s)/PR(s)]

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@jspspike jspspike requested a review from a team as a code owner October 10, 2023 19:33
@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2023

🦋 Changeset detected

Latest commit: f240495

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jspspike jspspike marked this pull request as draft October 10, 2023 19:33
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6661021807/npm-package-wrangler-4149

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6661021807/npm-package-wrangler-4149

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6661021807/npm-package-wrangler-4149 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6661021807/npm-package-cloudflare-pages-shared-4149

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.15.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare 3.20231025.0 3.20231025.0
workerd 1.20231025.0 1.20231025.0
workerd --version 1.20231025.0 2023-10-25

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #4149 (f240495) into main (a027b57) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4149      +/-   ##
==========================================
+ Coverage   75.39%   75.44%   +0.05%     
==========================================
  Files         223      223              
  Lines       12330    12334       +4     
  Branches     3186     3188       +2     
==========================================
+ Hits         9296     9306      +10     
+ Misses       3034     3028       -6     
Files Coverage Δ
packages/wrangler/src/index.ts 83.44% <ø> (ø)
packages/wrangler/src/tail/createTail.ts 84.78% <100.00%> (+1.44%) ⬆️

... and 4 files with indirect coverage changes

@jspspike jspspike force-pushed the jspspike/tail-proxy branch from aa8d902 to f240495 Compare October 26, 2023 23:53
@jspspike jspspike marked this pull request as ready for review October 26, 2023 23:53
@jspspike jspspike changed the title Potential fix proxy not working with wrangler tail Fix proxy not working with wrangler tail Oct 26, 2023
@jspspike jspspike merged commit 7e05f38 into main Oct 27, 2023
@jspspike jspspike deleted the jspspike/tail-proxy branch October 27, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants