Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log size of additional modules #4198

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

penalosa
Copy link
Contributor

Fixes #1313

What this PR solves / how to test:

Log the size of additional modules uploaded as part of your worker

Associated docs issue(s)/PR(s):

  • [insert associated docs issue(s)/PR(s)]

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@penalosa penalosa linked an issue Oct 17, 2023 that may be closed by this pull request
2 tasks
@penalosa penalosa requested a review from a team as a code owner October 17, 2023 13:09
@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2023

🦋 Changeset detected

Latest commit: 7c2da27

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@penalosa penalosa requested a review from a team as a code owner October 17, 2023 13:12
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6625925109/npm-package-wrangler-4198

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6625925109/npm-package-wrangler-4198

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6625925109/npm-package-wrangler-4198 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6625925109/npm-package-cloudflare-pages-shared-4198

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.14.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare 3.20231016.0 3.20231016.0
workerd 1.20231016.0 1.20231016.0
workerd --version 1.20231016.0 2023-10-16

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! ✅ Maybe add a changeset?

@admah
Copy link
Contributor

admah commented Oct 23, 2023

@penalosa is this good to be merged? Looks like it might need a changeset first?

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #4198 (7c2da27) into main (4deda52) will increase coverage by 0.02%.
Report is 44 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4198      +/-   ##
==========================================
+ Coverage   75.37%   75.40%   +0.02%     
==========================================
  Files         223      223              
  Lines       12217    12261      +44     
  Branches     3159     3171      +12     
==========================================
+ Hits         9209     9245      +36     
- Misses       3008     3016       +8     
Files Coverage Δ
...r/src/deployment-bundle/find-additional-modules.ts 95.58% <100.00%> (+0.13%) ⬆️

... and 16 files with indirect coverage changes

@penalosa penalosa merged commit b404ab7 into main Oct 25, 2023
20 checks passed
@penalosa penalosa deleted the 1313-polish-bundle-reporter-filesassets-details branch October 25, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

polish: [bundle reporter] Files/Assets Details
3 participants