fix the generation of invalid/incorrect scripts for Next.js applications

[dario-piotrowicz]

resolves #3654

[changeset-bot]

🦋 Changeset detected

Latest commit: cce4096

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
create-cloudflare	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6553202418/npm-package-wrangler-4200

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6553202418/npm-package-wrangler-4200

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6553202418/npm-package-wrangler-4200 dev path/to/script.js

Additional artifacts:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6553202418/npm-package-cloudflare-pages-shared-4200

Note that these links will no longer work once the GitHub Actions artifact expires.

---

wrangler@3.13.2 includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	3.20231016.0	3.20231016.0
workerd	1.20231016.0	1.20231016.0
workerd --version	1.20231016.0	2023-10-16

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[dario-piotrowicz]

@jculvey when reviewing this PR please have a look at the details I put here: #3654 (comment) as that shows what is the actual correct output we want

(PS: I am tempted to add unit tests to check that we're hitting that precise output but it feels a bit of an overkill and inconsistent with our other frameworks so I am a bit hesitant in doing that 😕)

[admah]

@dario-piotrowicz is this waiting on anything or can it be merged?

[dario-piotrowicz]

@admah yeah sorry about it 🙇, it can be merged, but I wanted to do one last double check to make extra sure that the changes are correct, I'll do that today and merge the PR if everything is as it should be, I hope that's fine

[admah]

That's great! I just wanted to make sure the PR was good and not forgotten 😄

[dario-piotrowicz]

I've tested it with npm and pnpm, bun doesn't seem able to run the package locally so I'll need to test it with the beta version after merging, I think we do have issues with yarn so that's also to be checked later

But I think this should be good 🙂 (even if there were to be something a bit off this is still a net improvement since the current scripts do not work anyways)