Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wrangler] Clean up compatibility fallback warnings #4209

Merged
merged 2 commits into from
Oct 24, 2023
Merged

[wrangler] Clean up compatibility fallback warnings #4209

merged 2 commits into from
Oct 24, 2023

Commits on Oct 18, 2023

  1. Only show compatibility date fallback warning if new version available 

    When a compatibility date greater than the installed `workerd` version
is selected, Miniflare logs a warning. The intention here is to warn
users if they've set a compatibility date, but haven't updated
`workerd`, so features they've requested won't be available.
The problem is that this warning is only actionable if there's an
update available. This change suppresses the warning if there's no
new version available.
    @mrbbot
    mrbbot committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    398fcfe View commit details
    Browse the repository at this point in the history

  2. Use installed workerd version as default compat date instead of now 

    `wrangler dev` would previously use the current date as the default
compatibility date if one wasn't set in `wrangler.toml`. Before the
previous commit, this would show a warning if it was greater than the
installed `workerd` version. Whilst using the current date as the
default would no longer log a warning with this change, if there was
an update it would. This change sets the default to the `workerd`
version instead.
    @mrbbot
    mrbbot committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    7c3e500 View commit details
    Browse the repository at this point in the history