use shell-quote.quote(args) instead of args.join(" ")
#4215
Conversation
🦋 Changeset detectedLatest commit: bd08fa0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
RamIdeas
changed the title
shell-quote.quote(cmd) instead of cmd.join(" ")shell-quote.quote(args) instead of args.join(" ")
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6612943814/npm-package-wrangler-4215You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6612943814/npm-package-wrangler-4215Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6612943814/npm-package-wrangler-4215 dev path/to/script.jsAdditional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6612943814/npm-package-cloudflare-pages-shared-4215Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
RamIdeas
force-pushed
the
shell-quote-insteadof-join
branch
from
54a3f04
to
43458e8
Compare
| @@ -43,7 +43,7 @@ describe("generate", () => { | |||
| `"✨ Created no-template/wrangler.toml"` | |||
| ); | |||
| expect(std.warn).toMatchInlineSnapshot(` | |||
| "[33m▲ [43;33m[[43;30mWARNING[43;33m][0m [1mThe \`init\` command is no longer supported. Please use \`mockpm create cloudflare@2 no-template\` instead.[0m | |||
| "[33m▲ [43;33m[[43;30mWARNING[43;33m][0m [1mThe \`init\` command is no longer supported. Please use \`mockpm create cloudflare/@2 no-template\` instead.[0m | |||
There was a problem hiding this comment.
something weird is going on with jest snapshot encoding
- double backslash
\\is changed into a forward slash/ - this doesn't effect real usage:
\\@is what is actually returned from shell-quote and that works
You can confirm by running wrangler init (with this PRs build) and seeing the C3 command logged out correctly
which will be stringified
something weird is going on with jest snapshot encoding - double backslash \\ is changed into a forward slash / - this doesn't effect real usage \\@ is what is actually returned from shell-quote and that works
RamIdeas
force-pushed
the
shell-quote-insteadof-join
branch
from
43458e8
to
bd08fa0
Compare
|
Noticed the C3 E2E pnpm test failings with the Nuxt framework. I'm rebasing from main in hopes the test is fixed there |
Codecov Report
@@ Coverage Diff @@
## main #4215 +/- ##
=========================================
+ Coverage 0 75.36% +75.36%
=========================================
Files 0 223 +223
Lines 0 12259 +12259
Branches 0 3171 +3171
=========================================
+ Hits 0 9239 +9239
- Misses 0 3020 +3020
|
What this PR solves / how to test:
Follow-up to #4080, prompted by #4211 (comment)
In my previous PR introducing
shell-quote, I searched for instances ofsplit(" ")and changed them toshellquote.parse(cmd)In this PR, I searched for instances of
join(" ")and changed them toshellquote.quote(args)Author has included the following, where applicable:
Reviewer is to perform the following, as applicable:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr reviewso future reviewers can take inspiration and learn from it.