-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for unsafe eval bindings to miniflare #4322
Conversation
🦋 Changeset detectedLatest commit: 2830465 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6732252267/npm-package-wrangler-4322 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6732252267/npm-package-wrangler-4322 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6732252267/npm-package-wrangler-4322 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6732252267/npm-package-miniflare-4322 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6732252267/npm-package-cloudflare-pages-shared-4322 Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
Codecov Report
@@ Coverage Diff @@
## main #4322 +/- ##
==========================================
+ Coverage 75.34% 75.38% +0.04%
==========================================
Files 223 223
Lines 12341 12341
Branches 3190 3190
==========================================
+ Hits 9298 9303 +5
+ Misses 3043 3038 -5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 😃 Added a couple minor comments, then I'll approve. 👍
No description provided.