-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: provide proper error message for missing DOs #4337
Conversation
🦋 Changeset detectedLatest commit: c70dbc3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6783417872/npm-package-wrangler-4337 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6783417872/npm-package-wrangler-4337 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6783417872/npm-package-wrangler-4337 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6783417872/npm-package-miniflare-4337 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6783417872/npm-package-cloudflare-pages-shared-4337 Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
New error message lgtm! |
Codecov Report
@@ Coverage Diff @@
## main #4337 +/- ##
==========================================
+ Coverage 75.33% 75.35% +0.02%
==========================================
Files 223 223
Lines 12344 12350 +6
Branches 3193 3195 +2
==========================================
+ Hits 9299 9306 +7
+ Misses 3045 3044 -1
|
Fixes #3738.
What this PR solves / how to test: Improves error message for a worker missing a durable object export
Author has addressed the following:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.