Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: provide proper error message for missing DOs #4337

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Fix: provide proper error message for missing DOs #4337

merged 1 commit into from
Nov 7, 2023

Conversation

Skye-31
Copy link
Contributor

@Skye-31 Skye-31 commented Nov 3, 2023

Fixes #3738.

What this PR solves / how to test: Improves error message for a worker missing a durable object export

Author has addressed the following:

  • Tests
    • Included
    • Not necessary because:
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because:
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because: Bugfix

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@Skye-31 Skye-31 requested a review from a team as a code owner November 3, 2023 13:17
Copy link

changeset-bot bot commented Nov 3, 2023

🦋 Changeset detected

Latest commit: c70dbc3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 3, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6783417872/npm-package-wrangler-4337

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6783417872/npm-package-wrangler-4337

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6783417872/npm-package-wrangler-4337 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6783417872/npm-package-miniflare-4337
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6783417872/npm-package-cloudflare-pages-shared-4337

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.15.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231025.1
workerd 1.20231030.0 1.20231030.0
workerd --version 1.20231030.0 2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@vy-ton
Copy link

vy-ton commented Nov 6, 2023

New error message lgtm!

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #4337 (c70dbc3) into main (102e15f) will increase coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4337      +/-   ##
==========================================
+ Coverage   75.33%   75.35%   +0.02%     
==========================================
  Files         223      223              
  Lines       12344    12350       +6     
  Branches     3193     3195       +2     
==========================================
+ Hits         9299     9306       +7     
+ Misses       3045     3044       -1     
Files Coverage Δ
packages/wrangler/src/deployment-bundle/bundle.ts 87.82% <50.00%> (-2.09%) ⬇️

... and 3 files with indirect coverage changes

@Skye-31 Skye-31 merged commit 6c8f41f into cloudflare:main Nov 7, 2023
19 of 20 checks passed
@Skye-31 Skye-31 deleted the fix-3738 branch November 7, 2023 14:10
@workers-devprod workers-devprod mentioned this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Uncaught TypeError: Class extends value undefined is not a constructor or null
4 participants