-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove unneeded polyfills from the Angular template #4339
Conversation
🦋 Changeset detectedLatest commit: da76e11 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
`performance.mark` and `global` polyfills are no longer needed in a v17 application.
ce63030
to
f5f2ca7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! I'll give it a try locally before we merge.
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6782844954/npm-package-wrangler-4339 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6782844954/npm-package-wrangler-4339 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6782844954/npm-package-wrangler-4339 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6782844954/npm-package-miniflare-4339 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6782844954/npm-package-cloudflare-pages-shared-4339 Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
Codecov Report
@@ Coverage Diff @@
## main #4339 +/- ##
==========================================
+ Coverage 75.35% 75.36% +0.01%
==========================================
Files 223 223
Lines 12341 12344 +3
Branches 3190 3193 +3
==========================================
+ Hits 9299 9303 +4
+ Misses 3042 3041 -1 |
Works well locally! I had to fix a formatting issue. But once the CI is green we can merge. |
performance.mark
andglobal
polyfills are no longer needed in a v17 application.See: angular/angular#52505