-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fetch): use pages for pagination instead of cursor #4402
Conversation
🦋 Changeset detectedLatest commit: 790d61a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Since it is hard to write automated test for this, I recommend pulling this down and somehow testing it manually before merging. |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6849645063/npm-package-wrangler-4402 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6849645063/npm-package-wrangler-4402 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6849645063/npm-package-wrangler-4402 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6849645063/npm-package-miniflare-4402 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6849645063/npm-package-cloudflare-pages-shared-4402 Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
Codecov Report
@@ Coverage Diff @@
## main #4402 +/- ##
==========================================
+ Coverage 75.28% 75.50% +0.21%
==========================================
Files 223 225 +2
Lines 12357 12478 +121
Branches 3198 3239 +41
==========================================
+ Hits 9303 9421 +118
- Misses 3054 3057 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also be used when fetching the list of accounts for wrangler whoami
Cheers @penalosa 🙌 |
Fixes #4349
What this PR solves / how to test:
The existing
fetchListResult
handler for fetching potentially paginated results doesn't work for endpoints that don't implementcursor
.This PR adds a naive handler that uses
page
, assumingresult_info
provided by the endpoint containspage
,per_page
, andtotal
FYI @celso