[wrangler] feat: source map logged strings

[mrbbot]

Fixes #3383 and closes #3739.

What this PR solves / how to test:

Previously, Wrangler would only apply source mapping to uncaught exceptions. This meant if you caught an exception and logged its stack trace, the call sites would reference built JavaScript files as opposed to source files. This change looks for stack traces in logged messages, and tries to source map them.

Note source mapping is only applied when outputting logs. Error#stack does not return a source mapped stack trace. This means the actual runtime value of new Error().stack and the output from console.log(new Error().stack) may be different.

To test this, run the following worker with wrangler dev:

interface Env {
}

export default <ExportedHandler<Env>>{
  fetch() {
    console.log(new Error("1"));
    console.log(new Error("2").stack);
    console.log({ error: new Error("3").stack });
  }
}

Note how source mapping is applied in all cases.

Author has addressed the following:

• Tests
  • Included
  • Not necessary because:
• Changeset (Changeset guidelines)
  • Included
  • Not necessary because:
• Associated docs
  • Issue(s)/PR(s):
  • Not necessary because:

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

[changeset-bot]

🦋 Changeset detected

Latest commit: fac2f99

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
wrangler	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7210693986/npm-package-wrangler-4423

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7210693986/npm-package-wrangler-4423

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7210693986/npm-package-wrangler-4423 dev path/to/script.js

Additional artifacts:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7210693986/npm-package-miniflare-4423

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7210693986/npm-package-cloudflare-pages-shared-4423

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7210693986/npm-package-create-cloudflare-4423

Note that these links will no longer work once the GitHub Actions artifact expires.

---

wrangler@3.20.0 includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	workspace:*	3.20231030.4
workerd	1.20231030.0	1.20231030.0
workerd --version	1.20231030.0	2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[codecov]

Codecov Report

Merging #4423 (0fd9b75) into main (6639468) will decrease coverage by 0.12%.
Report is 2 commits behind head on main.
The diff coverage is 36.61%.

❗ Current head 0fd9b75 differs from pull request most recent head fac2f99. Consider uploading reports for the commit fac2f99 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4423      +/-   ##
==========================================
- Coverage   75.55%   75.44%   -0.12%     
==========================================
  Files         242      242              
  Lines       12909    12957      +48     
  Branches     3320     3331      +11     
==========================================
+ Hits         9753     9775      +22     
- Misses       3156     3182      +26     

Files	Coverage Δ
packages/wrangler/src/dev/miniflare.ts	60.93% <66.66%> (+0.18%)	⬆️
packages/wrangler/src/dev/inspect.ts	6.99% <33.33%> (+0.56%)	⬆️
packages/wrangler/src/sourcemap.ts	23.30% <35.38%> (+21.60%)	⬆️

... and 1 file with indirect coverage changes

[mrbbot]

Looks like source mapping is slightly broken on Windows. 😕 Will investigate this when I'm next in the office.

[petebacondarwin]

Looks like source mapping is slightly broken on Windows. 😕 Will investigate this when I'm next in the office.

Equally I could take a look for you when I am next at home.

[mrbbot]

Fixed this on Windows with fac2f99. It looks like source-map-support has a few bugs resolving paths on Windows, and isn't really maintained anymore. I've switched to @cspotcode/source-map-support which has the required fixes, and is used by ts-node. 👍

[BrandonNoad]

@mrbbot will these changes help out at all with logging stack traces for Cloudflare Pages apps (deployed with wrangler pages deploy)?

e.g. #4234

[mrbbot]

@BrandonNoad unfortunately not. Deployed Workers and Pages Functions do not support source mapping yet.

[petebacondarwin]

LGTM - just added e2e test label.

[petebacondarwin]

E2Es are green and I tried this out on a local Windows machine. Ship it!