Log file fixes #4488
Log file fixes #4488
Conversation
instead of project root .wrangler frameworks may be watching the project root .wrangler dir for changes causing an infinite loop of update logs e.g. #4482
+ update log emoji to 🪵 instead of 🐛 since it's not just a debug log file anymore
🦋 Changeset detectedLatest commit: b953b3f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6961188089/npm-package-wrangler-4488You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6961188089/npm-package-wrangler-4488Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6961188089/npm-package-wrangler-4488 dev path/to/script.jsAdditional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6961188089/npm-package-miniflare-4488npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6961188089/npm-package-cloudflare-pages-shared-4488Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4488 +/- ##
==========================================
- Coverage 75.27% 75.26% -0.02%
==========================================
Files 226 226
Lines 12568 12570 +2
Branches 3260 3261 +1
==========================================
Hits 9461 9461
- Misses 3107 3109 +2
|
since it's now in the home directory, no longer near the cwd
so not to have include the *very* visible bright-yellow [WARNING] indicator
Fixes #4482.
What this PR solves / how to test:
Changes the default directory wrangler writes log files to.
Also writes the log file location to stderr (as warning) to avoid polluting stdout (some commands print json to stdout). Further, now only prints when the log file contains an error message to avoid pointing the user to this file unnecessarily.
Author has addressed the following:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr reviewso future reviewers can take inspiration and learn from it.