-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add took recursive isolate lock
warning to workerd output exceptions
#4511
Conversation
🦋 Changeset detectedLatest commit: 3dc641c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7176149091/npm-package-wrangler-4511 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7176149091/npm-package-wrangler-4511 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7176149091/npm-package-wrangler-4511 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7176149091/npm-package-miniflare-4511 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7176149091/npm-package-cloudflare-pages-shared-4511 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7176149091/npm-package-create-cloudflare-4511 Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4511 +/- ##
==========================================
+ Coverage 75.53% 75.59% +0.05%
==========================================
Files 242 242
Lines 12918 12922 +4
Branches 3324 3326 +2
==========================================
+ Hits 9758 9768 +10
+ Misses 3160 3154 -6
|
Hey @huw! 👋 Thanks for this PR! Would you be able to format the changed file (run |
This PR adapts the code in #4341 to resolve cloudflare/workerd#706 (or, at least, it suppresses the warnings from it).
@kentonv says the
took recursive isolate lock
warning doesn’t represent any actual problems in the user’s code and is just there for Cloudflare’s internal reporting, so it’s safe to ignore in local dev: