Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add took recursive isolate lock warning to workerd output exceptions #4511

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

huw
Copy link
Contributor

@huw huw commented Nov 26, 2023

This PR adapts the code in #4341 to resolve cloudflare/workerd#706 (or, at least, it suppresses the warnings from it).

@kentonv says the took recursive isolate lock warning doesn’t represent any actual problems in the user’s code and is just there for Cloudflare’s internal reporting, so it’s safe to ignore in local dev:

This is more of a warning than an error; nothing will actually go wrong. I added this log statement because we want to drop support for taking this lock recursively, so I wanted to find out where it happens, but I failed to follow-up. :/

@huw huw requested a review from a team as a code owner November 26, 2023 11:22
Copy link

changeset-bot bot commented Nov 26, 2023

🦋 Changeset detected

Latest commit: 3dc641c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 11, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7176149091/npm-package-wrangler-4511

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7176149091/npm-package-wrangler-4511

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7176149091/npm-package-wrangler-4511 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7176149091/npm-package-miniflare-4511
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7176149091/npm-package-cloudflare-pages-shared-4511
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7176149091/npm-package-create-cloudflare-4511

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.19.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231030.3
workerd 1.20231030.0 1.20231030.0
workerd --version 1.20231030.0 2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #4511 (3dc641c) into main (ba9b88f) will increase coverage by 0.05%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4511      +/-   ##
==========================================
+ Coverage   75.53%   75.59%   +0.05%     
==========================================
  Files         242      242              
  Lines       12918    12922       +4     
  Branches     3324     3326       +2     
==========================================
+ Hits         9758     9768      +10     
+ Misses       3160     3154       -6     
Files Coverage Δ
packages/wrangler/src/dev/miniflare.ts 61.21% <100.00%> (+1.21%) ⬆️

... and 6 files with indirect coverage changes

@mrbbot
Copy link
Contributor

mrbbot commented Dec 11, 2023

Hey @huw! 👋 Thanks for this PR! Would you be able to format the changed file (run pnpm prettify in the root)? Then we can get this merged... 🙂

@mrbbot mrbbot merged commit 6639468 into cloudflare:main Dec 14, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error: took recursive isolate lock; kj::getStackTrace() on storage.put
3 participants