Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C3 e2es: skip qwik and vue unsupported checks #4568

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Conversation

dario-piotrowicz
Copy link
Member

No description provided.

@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner December 7, 2023 17:09
Copy link

changeset-bot bot commented Dec 7, 2023

⚠️ No Changeset found

Latest commit: 509a848

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 7, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7131716822/npm-package-wrangler-4568

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7131716822/npm-package-wrangler-4568

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7131716822/npm-package-wrangler-4568 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7131716822/npm-package-miniflare-4568
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7131716822/npm-package-cloudflare-pages-shared-4568
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7131716822/npm-package-create-cloudflare-4568

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.19.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231030.3
workerd 1.20231030.0 1.20231030.0
workerd --version 1.20231030.0 2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #4568 (509a848) into main (be9a296) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4568      +/-   ##
==========================================
+ Coverage   75.41%   75.45%   +0.03%     
==========================================
  Files         241      241              
  Lines       12867    12867              
  Branches     3315     3315              
==========================================
+ Hits         9704     9709       +5     
+ Misses       3163     3158       -5     

see 6 files with indirect coverage changes

@dario-piotrowicz dario-piotrowicz changed the title C3 e2es: don't test vue on windows C3 e2es: skip qwik and vue unsupported checks Dec 7, 2023
@dario-piotrowicz dario-piotrowicz merged commit 70f634c into main Dec 7, 2023
24 checks passed
@dario-piotrowicz dario-piotrowicz deleted the vue-windows branch December 7, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants