Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert workerd version pinned #4574

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Assert workerd version pinned #4574

merged 1 commit into from
Dec 8, 2023

Conversation

mrbbot
Copy link
Contributor

@mrbbot mrbbot commented Dec 8, 2023

Closes DEVX-1049

What this PR solves / how to test:

This PR ensures miniflare's workerd version is pinned as part of CI. Specifically, the Create Pull Request Prerelease job will fail here...

- name: Extract runtime versions
run: node .github/extract-runtime-versions.mjs # extract versions before modifying version to include commit hash

...if workerd isn't pinned.

Author has addressed the following:

  • Tests
    • Included
    • Not necessary because:
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because: internal change to CI
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because: internal change to CI

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@mrbbot mrbbot requested a review from a team as a code owner December 8, 2023 10:54
Copy link

changeset-bot bot commented Dec 8, 2023

⚠️ No Changeset found

Latest commit: 277cedf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #4574 (277cedf) into main (70f634c) will increase coverage by 0.04%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4574      +/-   ##
==========================================
+ Coverage   75.41%   75.46%   +0.04%     
==========================================
  Files         241      241              
  Lines       12867    12867              
  Branches     3315     3315              
==========================================
+ Hits         9704     9710       +6     
+ Misses       3163     3157       -6     

see 5 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Dec 8, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7140471908/npm-package-wrangler-4574

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7140471908/npm-package-wrangler-4574

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7140471908/npm-package-wrangler-4574 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7140471908/npm-package-miniflare-4574
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7140471908/npm-package-cloudflare-pages-shared-4574
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7140471908/npm-package-create-cloudflare-4574

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.19.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231030.3
workerd 1.20231030.0 1.20231030.0
workerd --version 1.20231030.0 2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@mrbbot mrbbot merged commit 96faca4 into main Dec 8, 2023
17 checks passed
@mrbbot mrbbot deleted the bcoll/assert-workerd-pinned branch December 8, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants