Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update c3-dependabot-versioning-prs.yml #4585

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Update c3-dependabot-versioning-prs.yml #4585

merged 1 commit into from
Dec 11, 2023

Conversation

penalosa
Copy link
Contributor

Fixes # [insert GH or internal issue number(s)].

What this PR solves / how to test:

Author has addressed the following:

  • Tests
    • Included
    • Not necessary because:
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because:
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because:

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@penalosa penalosa requested a review from a team as a code owner December 11, 2023 10:24
Copy link

changeset-bot bot commented Dec 11, 2023

⚠️ No Changeset found

Latest commit: 09d3299

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7166058610/npm-package-wrangler-4585

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7166058610/npm-package-wrangler-4585

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7166058610/npm-package-wrangler-4585 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7166058610/npm-package-miniflare-4585
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7166058610/npm-package-cloudflare-pages-shared-4585
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7166058610/npm-package-create-cloudflare-4585

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.19.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231030.3
workerd 1.20231030.0 1.20231030.0
workerd --version 1.20231030.0 2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@workers-devprod workers-devprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this. Assuming dependendabot PRs continue to work, we can delete the old secret from the repo.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #4585 (09d3299) into main (96faca4) will increase coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4585      +/-   ##
==========================================
+ Coverage   75.41%   75.48%   +0.06%     
==========================================
  Files         241      241              
  Lines       12867    12867              
  Branches     3315     3315              
==========================================
+ Hits         9704     9713       +9     
+ Misses       3163     3154       -9     

see 6 files with indirect coverage changes

@penalosa penalosa merged commit 6f05d61 into main Dec 11, 2023
17 checks passed
@penalosa penalosa deleted the penalosa-patch-7 branch December 11, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants