[wrangler] fix: sanitise error reports and only report unknown errors #4707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1c9817b.
Removes PII information from Sentry events
Introduces a new `UserError` base class. Instances of this class won't be reported to Sentry.
🦋 Changeset detectedLatest commit: 4b12346 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7424161887/npm-package-wrangler-4707You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7424161887/npm-package-wrangler-4707Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7424161887/npm-package-wrangler-4707 dev path/to/script.jsAdditional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7424161887/npm-package-miniflare-4707npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7424161887/npm-package-cloudflare-pages-shared-4707npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7424161887/npm-package-create-cloudflare-4707 --no-auto-updateNote that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
mrbbot
force-pushed
the
bcoll/re-enable-sentry
branch
from
b8c16b9
to
ce03c92
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4707 +/- ##
==========================================
+ Coverage 75.58% 75.70% +0.11%
==========================================
Files 243 243
Lines 13096 13200 +104
Branches 3375 3388 +13
==========================================
+ Hits 9899 9993 +94
- Misses 3197 3207 +10
|
mrbbot
force-pushed
the
bcoll/re-enable-sentry
branch
from
ce03c92
to
4b12346
Compare
rozenmd
approved these changes
Jan 11, 2024
penalosa
approved these changes
Jan 11, 2024
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DEVX-1117
What this PR solves / how to test:
This PR tries to remove PII from Sentry error reports, and also ensures we're not reporting user errors that aren't actionable by us. User errors now extend a new
UserErrorbase class that doesn't get reported. Annotating user errors is a separate commit for easier reviewing.To test this, try run
wrangler dev i-dont-exist.js(you'll need to use a pre-release build with Sentry enabled). Notice an error is thrown but you're not prompted to report this.Author has addressed the following:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr reviewso future reviewers can take inspiration and learn from it.