Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gv/cli pr draft #4764

Closed
wants to merge 16 commits into from
Closed

Gv/cli pr draft #4764

wants to merge 16 commits into from

Conversation

gabivlj
Copy link
Contributor

@gabivlj gabivlj commented Jan 17, 2024

Fixes # [insert GH or internal issue number(s)].

What this PR solves / how to test:

Author has addressed the following:

  • Tests
    • Included
    • Not necessary because:
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because:
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because:

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

  - MultiSelectPrompt is a new component that allows the user to select multiple options.
  - SelectRefreshablePrompt is a component that allows refreshing options.

New renderers: select list renderer is a renderer that can render a list below an option. It also has a smarter pagination. Makes use of SelectRefreshablePrompt.

getSelectRenderers now supports simple infinite scroll and multi select.
… PR feedback

- Remove inferYargs and adjust all commands that tried to pass args
  object directly to not do it anymore.
- asJson is moved to a common file, and have the concept of
  CommonYargsArgvJSON.
- Cleanup cloudchamber command definitions.
Copy link

changeset-bot bot commented Jan 17, 2024

🦋 Changeset detected

Latest commit: 0ed1b60

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@cloudflare/cli Minor
create-cloudflare Minor
wrangler Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7560231086/npm-package-wrangler-4764

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7560231086/npm-package-wrangler-4764

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7560231086/npm-package-wrangler-4764 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7560231086/npm-package-miniflare-4764
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7560231086/npm-package-cloudflare-pages-shared-4764
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7560231086/npm-package-create-cloudflare-4764 --no-auto-update

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.22.5 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231218.2
workerd 1.20231218.0 1.20231218.0
workerd --version 1.20231218.0 2023-12-18

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@gabivlj gabivlj closed this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant