Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump undici versions to 5.28.2 #4768

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

petebacondarwin
Copy link
Contributor

This should clear out a bunch of dependabot PRs and also simplify our dependencies across the whole monorepo.

Copy link

changeset-bot bot commented Jan 18, 2024

🦋 Changeset detected

Latest commit: b3e4ee6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@cloudflare/cli Patch
create-cloudflare Patch
miniflare Patch
playground-preview-worker Patch
workers-playground Patch
wrangler Patch
@cloudflare/pages-shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@petebacondarwin petebacondarwin marked this pull request as ready for review January 18, 2024 10:06
@petebacondarwin petebacondarwin requested review from a team as code owners January 18, 2024 10:06
@petebacondarwin petebacondarwin added dependency Relating to dependency updates e2e Run e2e tests on a PR labels Jan 18, 2024
@petebacondarwin petebacondarwin self-assigned this Jan 18, 2024
Copy link
Contributor

github-actions bot commented Jan 18, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7624480505/npm-package-wrangler-4768

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4768/npm-package-wrangler-4768

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7624480505/npm-package-wrangler-4768 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7624480505/npm-package-create-cloudflare-4768 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7624480505/npm-package-miniflare-4768
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7624480505/npm-package-cloudflare-pages-shared-4768

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.23.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231218.2
workerd 1.20231218.0 1.20231218.0
workerd --version 1.20231218.0 2023-12-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin petebacondarwin requested a review from a team as a code owner January 18, 2024 17:25
@petebacondarwin petebacondarwin force-pushed the bump-undici-versions branch 2 times, most recently from 0778eaf to 5484662 Compare January 22, 2024 09:54
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (884e418) 71.47% compared to head (b3e4ee6) 71.52%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4768      +/-   ##
==========================================
+ Coverage   71.47%   71.52%   +0.04%     
==========================================
  Files         288      288              
  Lines       14829    14829              
  Branches     3729     3729              
==========================================
+ Hits        10599    10606       +7     
+ Misses       4230     4223       -7     

see 6 files with indirect coverage changes

@petebacondarwin petebacondarwin merged commit c3e410c into main Jan 23, 2024
23 of 24 checks passed
@petebacondarwin petebacondarwin deleted the bump-undici-versions branch January 23, 2024 13:06
@admah
Copy link
Contributor

admah commented Jan 23, 2024

@petebacondarwin will this cause the open dependabot PRs to close automatically?

@petebacondarwin
Copy link
Contributor Author

@admah - yep! I gave Dependabot a kick on those PRs and it closed them all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Relating to dependency updates e2e Run e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants