-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: remove ChatGPT plugin template #4657 #4775
Chore: remove ChatGPT plugin template #4657 #4775
Conversation
|
@anthonyringoet Thanks for creating a PR for this and sorry for the delay! We just landed a PR that refactors the way we handle templates in c3 and it looks like you've got some conflicts. The changes with the new template format should be pretty similar to what you have here (delete the folder, remove the entry from the template map, remove references in tests). Happy to help if you run into any issues rebasing/updating. |
38cdee9
to
535c528
Compare
@jculvey Reset my local branch to have the updates and removed it from that new version. |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7667372347/npm-package-wrangler-4775 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4775/npm-package-wrangler-4775 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7667372347/npm-package-wrangler-4775 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7667372347/npm-package-create-cloudflare-4775 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7667372347/npm-package-miniflare-4775 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7667372347/npm-package-cloudflare-pages-shared-4775 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
@anthonyringoet thanks for the changes! Would you mind adding a quick changeset with |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4775 +/- ##
==========================================
+ Coverage 70.56% 70.60% +0.04%
==========================================
Files 290 290
Lines 15100 15100
Branches 3832 3832
==========================================
+ Hits 10655 10662 +7
+ Misses 4445 4438 -7 |
Running the C3 e2e tests here #4844 |
535c528
to
b54b6bb
Compare
Fixes #4657
What this PR solves / how to test:
Removes ChatGPT plugin template.
Author has addressed the following:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.