Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: remove ChatGPT plugin template #4657 #4775

Merged

Conversation

anthonyringoet
Copy link
Contributor

@anthonyringoet anthonyringoet commented Jan 18, 2024

Fixes #4657

What this PR solves / how to test:
Removes ChatGPT plugin template.

Author has addressed the following:

  • Tests
    • Included
    • Not necessary because: removed functionality
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because: trivial?
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because:

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@anthonyringoet anthonyringoet requested a review from a team as a code owner January 18, 2024 15:59
Copy link

changeset-bot bot commented Jan 18, 2024

⚠️ No Changeset found

Latest commit: b54b6bb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jculvey
Copy link
Contributor

jculvey commented Jan 24, 2024

@anthonyringoet Thanks for creating a PR for this and sorry for the delay!

We just landed a PR that refactors the way we handle templates in c3 and it looks like you've got some conflicts. The changes with the new template format should be pretty similar to what you have here (delete the folder, remove the entry from the template map, remove references in tests). Happy to help if you run into any issues rebasing/updating.

@anthonyringoet
Copy link
Contributor Author

@jculvey Reset my local branch to have the updates and removed it from that new version.

Copy link
Contributor

github-actions bot commented Jan 25, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7667372347/npm-package-wrangler-4775

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4775/npm-package-wrangler-4775

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7667372347/npm-package-wrangler-4775 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7667372347/npm-package-create-cloudflare-4775 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7667372347/npm-package-miniflare-4775
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7667372347/npm-package-cloudflare-pages-shared-4775

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.24.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231218.3
workerd 1.20231218.0 1.20231218.0
workerd --version 1.20231218.0 2023-12-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@jculvey
Copy link
Contributor

jculvey commented Jan 25, 2024

@anthonyringoet thanks for the changes!

Would you mind adding a quick changeset with npx changeset along the lines of [C3] Removing ChatGPT plugin template?

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f4f38fc) 70.56% compared to head (535c528) 70.60%.
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4775      +/-   ##
==========================================
+ Coverage   70.56%   70.60%   +0.04%     
==========================================
  Files         290      290              
  Lines       15100    15100              
  Branches     3832     3832              
==========================================
+ Hits        10655    10662       +7     
+ Misses       4445     4438       -7     

see 6 files with indirect coverage changes

@petebacondarwin
Copy link
Contributor

Running the C3 e2e tests here #4844

@petebacondarwin petebacondarwin merged commit d9bade4 into cloudflare:main Jan 26, 2024
33 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧹 Chore: remove ChatGPT plugin template and option from C3
3 participants