Bring across @cloudflare/kv-asset-handler

[GregBrimble]

Adds @cloudflare/kv-asset-handler to workers-sdk.

A slightly wonky #4315.

# /path/to/filter.sh
#!/bin/sh

mkdir -p packages/kv-asset-handler
rsync -avC --remove-source-files . ./packages/kv-asset-handler

# in kv-asset-handler
FILTER_BRANCH_SQUELCH_WARNING=1 git filter-branch --tree-filter '/path/to/filter.sh'
git filter-repo --tag-rename '':'@cloudflare/kv-asset-handler@' --force
git filter-repo --tag-rename '@cloudflare/kv-asset-handler@v':'@cloudflare/kv-asset-handler@' --force

# in workers-sdk
git remote add kv-asset-handler-remote /path/to/kv-asset-handler
git fetch kv-asset-handler-remote
git checkout -b kv-asset-handler
git cherry-pick ..kv-asset-handler-remote/main --strategy-option theirs -m 1
# then spam `git cherry-pick --skip`

The only interesting commits are these four:

• b97d7b1
• dff495a
• 4df8de8
• c3faba1

[changeset-bot]

⚠️ No Changeset found

Latest commit: 91cca79

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7846804897/npm-package-wrangler-4782

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4782/npm-package-wrangler-4782

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7846804897/npm-package-wrangler-4782 dev path/to/script.js

Additional artifacts:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7846804897/npm-package-create-cloudflare-4782 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7846804897/npm-package-cloudflare-kv-asset-handler-4782

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7846804897/npm-package-miniflare-4782

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7846804897/npm-package-cloudflare-pages-shared-4782

Note that these links will no longer work once the GitHub Actions artifact expires.

---

wrangler@3.28.1 includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	workspace:*	3.20240129.1
workerd	1.20240129.0	1.20240129.0
workerd --version	1.20240129.0	2024-01-29

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[Cherry]

Nice to see this!! Is there any way to bring over the commit history like in #4315 - I feel there's a lot of nuance and history there that would be good to keep?

[GregBrimble]

Yup, absolutely can do. That's a good shout, thanks! :)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (05360e4) 70.45% compared to head (91cca79) 70.50%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4782      +/-   ##
==========================================
+ Coverage   70.45%   70.50%   +0.05%     
==========================================
  Files         295      295              
  Lines       15409    15409              
  Branches     3948     3948              
==========================================
+ Hits        10856    10864       +8     
+ Misses       4553     4545       -8     

see 6 files with indirect coverage changes

[petebacondarwin]

Github seems to think some of these users/teams don't exist.

[GregBrimble]

Yes, they need to be added to this repo. cc. @lrapoport-cf

[petebacondarwin]

LGTM.

I think this now opts kv-asset-handler into the Changesets based deployment process, right?

Also is there a PR in flight to "turn off" the old repository so that people don't accidentally deploy from there? And also to transfer and redirect issues to this repo?

[GregBrimble]

It does indeed. That was the primary motivation for it actually, since @cloudflare/kv-asset-handler is solely managed by wrangler-publisher in npm, but no human has the keys to that.

I have magical admin powers to merge this PR and archive the repo once this one is in.

I'll bring across all issues and label them with kv-asset-handler.