fix: ensure worker reloads when importing node:* modules

[mrbbot]

Fixes #4959.

What this PR solves / how to test:

#4499 introduced a bug which prevented reloads when importing node:* modules. The internal per-build seen cache was not cleared between builds, resulting in this branch being hit...

workers-sdk/packages/wrangler/src/deployment-bundle/esbuild-plugins/nodejs-compat.ts

Lines 28 to 30 in 1c4f163

	if (seen.has(specifier)) {
	return;
	}

...and the resolution failing. This change wraps that in an onStart(), so it's called at the start of each build, and also moves the caches inside the plugin, so multiple instances of the plugin can be created.

To test this, follow the reproduction instructions in #4959, no errors should be reported.

Author has addressed the following:

• Tests
  • Included
  • Not necessary because:
• Changeset (Changeset guidelines)
  • Included
  • Not necessary because:
• Associated docs
  • Issue(s)/PR(s):
  • Not necessary because: fixing a regression

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

[changeset-bot]

🦋 Changeset detected

Latest commit: a692499

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
wrangler	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7842962110/npm-package-wrangler-4962

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4962/npm-package-wrangler-4962

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7842962110/npm-package-wrangler-4962 dev path/to/script.js

Additional artifacts:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7842962110/npm-package-create-cloudflare-4962 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7842962110/npm-package-miniflare-4962

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7842962110/npm-package-cloudflare-pages-shared-4962

Note that these links will no longer work once the GitHub Actions artifact expires.

---

wrangler@3.28.0 includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	workspace:*	3.20240129.1
workerd	1.20240129.0	1.20240129.0
workerd --version	1.20240129.0	2024-01-29

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[penalosa]

Thanks for this!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ffafe8a) 70.43% compared to head (a692499) 70.45%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4962      +/-   ##
==========================================
+ Coverage   70.43%   70.45%   +0.02%     
==========================================
  Files         295      295              
  Lines       15407    15409       +2     
  Branches     3948     3948              
==========================================
+ Hits        10852    10857       +5     
+ Misses       4555     4552       -3     

Files	Coverage Δ
...deployment-bundle/esbuild-plugins/nodejs-compat.ts	96.87% <100.00%> (+6.55%)	⬆️
packages/wrangler/src/navigator-user-agent.ts	100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes