Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump workerd version number #5081

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

garrettgu10
Copy link
Contributor

Updates the version of workerd used by miniflare to 1.20240223.0.

Author has addressed the following:

  • Tests
    • Included
    • Not necessary because: workerd is tested against itself
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because:
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because: this is a simple version bump

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@garrettgu10 garrettgu10 requested a review from a team as a code owner February 23, 2024 20:53
Copy link

changeset-bot bot commented Feb 23, 2024

🦋 Changeset detected

Latest commit: f175298

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
miniflare Minor
@cloudflare/pages-shared Patch
@cloudflare/vitest-pool-workers Patch
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@garrettgu10 garrettgu10 marked this pull request as draft February 23, 2024 20:54
@garrettgu10 garrettgu10 marked this pull request as ready for review February 23, 2024 21:35
Copy link
Contributor

github-actions bot commented Feb 23, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8052357751/npm-package-wrangler-5081

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5081/npm-package-wrangler-5081

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8052357751/npm-package-wrangler-5081 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8052357751/npm-package-create-cloudflare-5081 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8052357751/npm-package-cloudflare-kv-asset-handler-5081
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8052357751/npm-package-miniflare-5081
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8052357751/npm-package-cloudflare-pages-shared-5081
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8052357751/npm-package-cloudflare-vitest-pool-workers-5081

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.29.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240208.0
workerd 1.20240223.1 1.20240223.1
workerd --version 1.20240223.1 2024-02-23

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a legitimate failure in workerd when used in the vitest-environment stuff.

@mrbbot
Copy link
Contributor

mrbbot commented Feb 26, 2024

Taking a look at this failure now... 👀

@mrbbot
Copy link
Contributor

mrbbot commented Feb 26, 2024

Put up a PR to fix the vitest-pool-workers issue: #5101. We should merge that PR first, then rebase this on main. 👍

@mrbbot
Copy link
Contributor

mrbbot commented Feb 26, 2024

Merged, should be good to rebase this now @garrettgu10 👍

@garrettgu10
Copy link
Contributor Author

Sweet! Thanks so much :-)

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.37%. Comparing base (d4b4c3a) to head (f175298).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5081      +/-   ##
==========================================
+ Coverage   70.33%   70.37%   +0.03%     
==========================================
  Files         298      298              
  Lines       15515    15515              
  Branches     3987     3987              
==========================================
+ Hits        10913    10919       +6     
+ Misses       4602     4596       -6     

see 6 files with indirect coverage changes

@petebacondarwin petebacondarwin merged commit 0c0949d into cloudflare:main Feb 27, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants