-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make wrangler types
always generate a d.ts
file for module worders
#5087
Conversation
🦋 Changeset detectedLatest commit: 9a9974d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8053372881/npm-package-wrangler-5087 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5087/npm-package-wrangler-5087 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8053372881/npm-package-wrangler-5087 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8053372881/npm-package-create-cloudflare-5087 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8053372881/npm-package-cloudflare-kv-asset-handler-5087 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8053372881/npm-package-miniflare-5087 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8053372881/npm-package-cloudflare-pages-shared-5087 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8053372881/npm-package-cloudflare-vitest-pool-workers-5087 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5087 +/- ##
==========================================
+ Coverage 70.33% 70.38% +0.04%
==========================================
Files 298 298
Lines 15515 15516 +1
Branches 3987 3988 +1
==========================================
+ Hits 10913 10921 +8
+ Misses 4602 4595 -7
|
Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>
What this PR solves / how to test:
Currently if a config file doesn't define any binding nor module, running
wrangler types
against such file would not produce ad.ts
file.Producing a
d.ts
file can however still be beneficial as it would define a correctenv interface (even if empty) that can be expanded/referenced by user code (this can
be particularly convenient for scaffolding tools that may want to always generate an
env interface).
Example:
Before
wrangler types --env-interface MyEnv
run with an emptywrangler.toml
filewould not generate any file, after these change it would instead generate a file with
the following content:
Author has addressed the following:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.