Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python support for remote dev #5119

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

garrettgu10
Copy link
Contributor

@garrettgu10 garrettgu10 commented Feb 28, 2024

This PR makes sure that the bundle type is set correctly in remote dev mode when the main module is a Python module. It also ensures that the source URL annotation is written in Python style when the entry point is a Python module.

Author has addressed the following:

  • Tests
    • Included
    • Not necessary because: one-line change on experimental feature
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because:
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because: one-line change on experimental feature; we will also be writing docs for the feature in the near future.

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@garrettgu10 garrettgu10 requested a review from a team as a code owner February 28, 2024 22:55
Copy link

changeset-bot bot commented Feb 28, 2024

🦋 Changeset detected

Latest commit: ba75bbd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 28, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8116146256/npm-package-wrangler-5119

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5119/npm-package-wrangler-5119

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8116146256/npm-package-wrangler-5119 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8116146256/npm-package-create-cloudflare-5119 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8116146256/npm-package-cloudflare-kv-asset-handler-5119
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8116146256/npm-package-miniflare-5119
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8116146256/npm-package-cloudflare-pages-shared-5119
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8116146256/npm-package-cloudflare-vitest-pool-workers-5119

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.30.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240223.0
workerd 1.20240223.1 1.20240223.1
workerd --version 1.20240223.1 2024-02-23

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.37%. Comparing base (54f6bfc) to head (ba75bbd).
Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5119      +/-   ##
==========================================
+ Coverage   70.33%   70.37%   +0.03%     
==========================================
  Files         298      298              
  Lines       15515    15543      +28     
  Branches     3987     4000      +13     
==========================================
+ Hits        10913    10938      +25     
- Misses       4602     4605       +3     
Files Coverage Δ
...kages/wrangler/src/deployment-bundle/source-url.ts 57.89% <100.00%> (+2.33%) ⬆️
packages/wrangler/src/dev/remote.tsx 11.73% <ø> (+3.81%) ⬆️

... and 11 files with indirect coverage changes

.changeset/kind-ducks-pay.md Outdated Show resolved Hide resolved
packages/wrangler/src/deployment-bundle/source-url.ts Outdated Show resolved Hide resolved
@mrbbot mrbbot merged commit b0bd413 into cloudflare:main Mar 4, 2024
17 checks passed
@workers-devprod workers-devprod mentioned this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants