Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use esbuild-plugins-node-modules-polyfill #5209

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented Mar 8, 2024

I accidentally closed the actual PR for this (#3832)
So this is the same commits reopened.

@petebacondarwin petebacondarwin added the e2e Run e2e tests on a PR label Mar 8, 2024
Copy link

changeset-bot bot commented Mar 8, 2024

🦋 Changeset detected

Latest commit: c32348f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Major
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@petebacondarwin petebacondarwin added this to the Wrangler v4 milestone Mar 8, 2024
Copy link
Contributor

github-actions bot commented Mar 8, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8307673192/npm-package-wrangler-5209

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5209/npm-package-wrangler-5209

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8307673192/npm-package-wrangler-5209 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8307673192/npm-package-create-cloudflare-5209 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8307673192/npm-package-cloudflare-kv-asset-handler-5209
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8307673192/npm-package-miniflare-5209
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8307673192/npm-package-cloudflare-pages-shared-5209
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8307673192/npm-package-cloudflare-vitest-pool-workers-5209

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.34.2 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240304.2
workerd 1.20240304.0 1.20240304.0
workerd --version 1.20240304.0 2024-03-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v4@2ecfeb9). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##             v4    #5209   +/-   ##
=====================================
  Coverage      ?   71.57%           
=====================================
  Files         ?      307           
  Lines         ?    16135           
  Branches      ?     4113           
=====================================
  Hits          ?    11549           
  Misses        ?     4586           
  Partials      ?        0           
Files Coverage Δ
packages/wrangler/src/deployment-bundle/bundle.ts 88.70% <100.00%> (ø)

@petebacondarwin petebacondarwin changed the title TEST: refactor: use esbuild-plugins-node-modules-polyfill refactor: use esbuild-plugins-node-modules-polyfill Mar 16, 2024
@petebacondarwin petebacondarwin changed the base branch from main to v4 March 16, 2024 11:54
@petebacondarwin petebacondarwin marked this pull request as ready for review March 16, 2024 11:54
@petebacondarwin petebacondarwin requested a review from a team as a code owner March 16, 2024 11:54
@petebacondarwin petebacondarwin requested a review from a team as a code owner March 16, 2024 12:17
@petebacondarwin petebacondarwin merged commit 97cb5b1 into v4 Mar 18, 2024
17 checks passed
@petebacondarwin petebacondarwin deleted the pr/MichaelDeBoey/3832 branch March 18, 2024 11:43
RamIdeas pushed a commit that referenced this pull request Sep 23, 2024
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants