Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wrangler] chore: bump workerd to 1.20240314.0 #5240

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

CarmenPopoviciu
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu commented Mar 13, 2024

This PR bumps the workerd version to 1.20240314.0, and fixes some failing tests as a result of this bump. The changes are based off of #5230.

The PR should address the following items:

  • Update the dev-env fixture snapshots
  • Update Miniflare snapshots, tests, and code for Queues changes (please refer to cloudflare/workerd@3cc6fd9)

In the process it also turned out a workers-types version bump was necessary in the vitest-pool-workers related work, which in turn required updating the code to support the Queue changes

What this PR solves / how to test

Fixes #[insert GH or internal issue number(s)].

Author has addressed the following

@CarmenPopoviciu CarmenPopoviciu requested a review from a team as a code owner March 13, 2024 20:26
Copy link

changeset-bot bot commented Mar 13, 2024

🦋 Changeset detected

Latest commit: 4fb3e44

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
miniflare Minor
@cloudflare/pages-shared Patch
@cloudflare/vitest-pool-workers Patch
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CarmenPopoviciu CarmenPopoviciu mentioned this pull request Mar 14, 2024
9 tasks
@CarmenPopoviciu CarmenPopoviciu force-pushed the carmen/workerd-1.20240312.0 branch from 6f47efc to 55273e5 Compare March 14, 2024 18:41
@CarmenPopoviciu CarmenPopoviciu changed the title [wrangler] chore: bump workerd to 1.20240312.0 [wrangler] chore: bump workerd to 1.20240314.0 Mar 14, 2024
Copy link
Contributor

github-actions bot commented Mar 14, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8326264874/npm-package-wrangler-5240

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5240/npm-package-wrangler-5240

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8326264874/npm-package-wrangler-5240 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8326264874/npm-package-create-cloudflare-5240 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8326264874/npm-package-cloudflare-kv-asset-handler-5240
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8326264874/npm-package-miniflare-5240
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8326264874/npm-package-cloudflare-pages-shared-5240
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8326264874/npm-package-cloudflare-vitest-pool-workers-5240

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.34.2 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240304.2
workerd 1.20240314.0 1.20240314.0
workerd --version 1.20240314.0 2024-03-14

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu CarmenPopoviciu force-pushed the carmen/workerd-1.20240312.0 branch 3 times, most recently from deb7cb3 to e59a552 Compare March 15, 2024 12:32
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.52%. Comparing base (4ce7a5d) to head (4fb3e44).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5240      +/-   ##
==========================================
+ Coverage   71.46%   71.52%   +0.05%     
==========================================
  Files         309      309              
  Lines       16098    16098              
  Branches     4111     4111              
==========================================
+ Hits        11505    11514       +9     
+ Misses       4593     4584       -9     

see 7 files with indirect coverage changes

@CarmenPopoviciu CarmenPopoviciu force-pushed the carmen/workerd-1.20240312.0 branch 2 times, most recently from 630223a to cf2cb7f Compare March 15, 2024 16:29
This commit bumps the `workerd` version to `1.20240314.0`,
and fixes some failing tests as a result of this bump.
@CarmenPopoviciu CarmenPopoviciu force-pushed the carmen/workerd-1.20240312.0 branch from cf2cb7f to 4fb3e44 Compare March 18, 2024 12:09
@lrapoport-cf lrapoport-cf merged commit 1720f0a into main Mar 18, 2024
15 checks passed
@lrapoport-cf lrapoport-cf deleted the carmen/workerd-1.20240312.0 branch March 18, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants