Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect --no-bundle when deploying a _worker.js/ directory in a Pages project #5380

Conversation

GregBrimble
Copy link
Member

DRAFT FOR LDW

Reverts #5368

Copy link

changeset-bot bot commented Mar 26, 2024

🦋 Changeset detected

Latest commit: 0271748

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8438302136/npm-package-wrangler-5380

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5380/npm-package-wrangler-5380

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8438302136/npm-package-wrangler-5380 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8438302136/npm-package-create-cloudflare-5380 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8438302136/npm-package-cloudflare-kv-asset-handler-5380
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8438302136/npm-package-miniflare-5380
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8438302136/npm-package-cloudflare-pages-shared-5380
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8438302136/npm-package-cloudflare-vitest-pool-workers-5380

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.37.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240320.0
workerd 1.20240320.1 1.20240320.1
workerd --version 1.20240320.1 2024-03-20

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@nprogers
Copy link
Contributor

nprogers commented Apr 3, 2024

@petebacondarwin @GregBrimble Are we waiting on anything to release these changes?

@petebacondarwin petebacondarwin marked this pull request as ready for review April 3, 2024 20:03
@petebacondarwin petebacondarwin requested review from a team as code owners April 3, 2024 20:03
@petebacondarwin
Copy link
Contributor

Now LDW is over we are clear to land this. (Once the CI is green!)

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 72.48%. Comparing base (904f91a) to head (0271748).
Report is 56 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5380      +/-   ##
==========================================
+ Coverage   72.43%   72.48%   +0.05%     
==========================================
  Files         319      319              
  Lines       16531    16534       +3     
  Branches     4235     4236       +1     
==========================================
+ Hits        11974    11985      +11     
+ Misses       4557     4549       -8     
Files Coverage Δ
packages/wrangler/src/api/pages/deploy.tsx 87.12% <100.00%> (+0.75%) ⬆️
packages/wrangler/src/pages/build.ts 70.79% <100.00%> (ø)
packages/wrangler/src/pages/dev.ts 35.43% <0.00%> (+2.31%) ⬆️
...ckages/wrangler/src/pages/functions/buildWorker.ts 74.28% <75.00%> (-0.23%) ⬇️

... and 4 files with indirect coverage changes

@petebacondarwin petebacondarwin merged commit 57d5658 into main Apr 8, 2024
17 checks passed
@petebacondarwin petebacondarwin deleted the revert-5368-revert-5200-optional-bundling-workerjs-directory branch April 8, 2024 16:35
@workers-devprod workers-devprod mentioned this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants