-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect --no-bundle when deploying a _worker.js/ directory in a Pages project #5380
Respect --no-bundle when deploying a _worker.js/ directory in a Pages project #5380
Conversation
…ctory in…" This reverts commit 904f91a.
🦋 Changeset detectedLatest commit: 0271748 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8438302136/npm-package-wrangler-5380 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5380/npm-package-wrangler-5380 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8438302136/npm-package-wrangler-5380 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8438302136/npm-package-create-cloudflare-5380 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8438302136/npm-package-cloudflare-kv-asset-handler-5380 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8438302136/npm-package-miniflare-5380 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8438302136/npm-package-cloudflare-pages-shared-5380 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8438302136/npm-package-cloudflare-vitest-pool-workers-5380 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
@petebacondarwin @GregBrimble Are we waiting on anything to release these changes? |
Now LDW is over we are clear to land this. (Once the CI is green!) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5380 +/- ##
==========================================
+ Coverage 72.43% 72.48% +0.05%
==========================================
Files 319 319
Lines 16531 16534 +3
Branches 4235 4236 +1
==========================================
+ Hits 11974 11985 +11
+ Misses 4557 4549 -8
|
DRAFT FOR LDW
Reverts #5368