-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fixture types after adding entrypoints #5499
Conversation
🦋 Changeset detectedLatest commit: ebddea5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8551445733/npm-package-wrangler-5499 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5499/npm-package-wrangler-5499 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8551445733/npm-package-wrangler-5499 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8551445733/npm-package-create-cloudflare-5499 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8551445733/npm-package-cloudflare-kv-asset-handler-5499 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8551445733/npm-package-miniflare-5499 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8551445733/npm-package-cloudflare-pages-shared-5499 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8551445733/npm-package-cloudflare-vitest-pool-workers-5499 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5499 +/- ##
==========================================
+ Coverage 72.11% 72.18% +0.07%
==========================================
Files 331 331
Lines 17175 17175
Branches 4386 4386
==========================================
+ Hits 12385 12398 +13
+ Misses 4790 4777 -13 |
* Bump workerd@1.20240403.0 * Remove no-longer-necessary rpc compatibility flags
What this PR solves / how to test
Looks like somehow we ended up with failing types after #5215. This adds the one line we're missing in a fixture test.
Author has addressed the following