Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C3: add test command to JS template. update failing test example in js template. #5517

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

admah
Copy link
Contributor

@admah admah commented Apr 4, 2024

What this PR solves / how to test

  • add test command to JS template. update failing test example in js template.

Author has addressed the following

@admah admah requested review from a team as code owners April 4, 2024 19:47
Copy link

changeset-bot bot commented Apr 4, 2024

🦋 Changeset detected

Latest commit: e1971ba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 4, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8560439278/npm-package-wrangler-5517

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5517/npm-package-wrangler-5517

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8560439278/npm-package-wrangler-5517 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8560439278/npm-package-create-cloudflare-5517 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8560439278/npm-package-cloudflare-kv-asset-handler-5517
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8560439278/npm-package-miniflare-5517
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8560439278/npm-package-cloudflare-pages-shared-5517
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8560439278/npm-package-cloudflare-vitest-pool-workers-5517

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.47.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240403.0
workerd 1.20240403.0 1.20240403.0
workerd --version 1.20240403.0 2024-04-03

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.23%. Comparing base (01ce6ec) to head (e1971ba).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5517      +/-   ##
==========================================
+ Coverage   72.15%   72.23%   +0.07%     
==========================================
  Files         332      332              
  Lines       17249    17249              
  Branches     4408     4408              
==========================================
+ Hits        12446    12459      +13     
+ Misses       4803     4790      -13     

see 7 files with indirect coverage changes

@admah admah merged commit 3c2eba8 into main Apr 10, 2024
25 checks passed
@admah admah deleted the admah/add-vitest-helloworld-js branch April 10, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants