-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pages default local port regression #5536
Conversation
🦋 Changeset detectedLatest commit: 3709c89 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8601321572/npm-package-wrangler-5536 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5536/npm-package-wrangler-5536 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8601321572/npm-package-wrangler-5536 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8601321572/npm-package-create-cloudflare-5536 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8601321572/npm-package-cloudflare-kv-asset-handler-5536 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8601321572/npm-package-miniflare-5536 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8601321572/npm-package-cloudflare-pages-shared-5536 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8601321572/npm-package-cloudflare-vitest-pool-workers-5536 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5536 +/- ##
==========================================
+ Coverage 72.44% 72.52% +0.07%
==========================================
Files 331 331
Lines 17298 17298
Branches 4422 4422
==========================================
+ Hits 12532 12545 +13
+ Misses 4766 4753 -13
|
thank you @Cherry for spotting this regression and fixing it <3. These changes will go out with the release tomorrow. Merging! |
What this PR solves / how to test
Fixes #5534
Author has addressed the following