Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pages default local port regression #5536

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

Cherry
Copy link
Contributor

@Cherry Cherry commented Apr 5, 2024

What this PR solves / how to test

Fixes #5534

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: no test coverage for this
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation

@Cherry Cherry requested review from a team as code owners April 5, 2024 20:06
Copy link

changeset-bot bot commented Apr 5, 2024

🦋 Changeset detected

Latest commit: 3709c89

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 5, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8601321572/npm-package-wrangler-5536

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5536/npm-package-wrangler-5536

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8601321572/npm-package-wrangler-5536 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8601321572/npm-package-create-cloudflare-5536 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8601321572/npm-package-cloudflare-kv-asset-handler-5536
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8601321572/npm-package-miniflare-5536
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8601321572/npm-package-cloudflare-pages-shared-5536
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8601321572/npm-package-cloudflare-vitest-pool-workers-5536

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.48.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240404.0
workerd 1.20240404.0 1.20240404.0
workerd --version 1.20240404.0 2024-04-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 72.52%. Comparing base (2789f26) to head (dbbdcf4).

❗ Current head dbbdcf4 differs from pull request most recent head 3709c89. Consider uploading reports for the commit 3709c89 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5536      +/-   ##
==========================================
+ Coverage   72.44%   72.52%   +0.07%     
==========================================
  Files         331      331              
  Lines       17298    17298              
  Branches     4422     4422              
==========================================
+ Hits        12532    12545      +13     
+ Misses       4766     4753      -13     
Files Coverage Δ
packages/wrangler/src/pages/dev.ts 31.92% <50.00%> (+2.10%) ⬆️

... and 6 files with indirect coverage changes

@CarmenPopoviciu
Copy link
Contributor

thank you @Cherry for spotting this regression and fixing it <3. These changes will go out with the release tomorrow. Merging!

@CarmenPopoviciu CarmenPopoviciu merged commit a7aa28a into cloudflare:main Apr 9, 2024
15 checks passed
@Cherry Cherry deleted the fix/pages-local-port branch April 9, 2024 13:32
@workers-devprod workers-devprod mentioned this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: regression/breaking change in default port with pages dev
2 participants