Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix DO migration docs links #5686

Conversation

Frederik-Baetens
Copy link
Contributor

This brings it in line with the wrangler.toml defined in most places.

Specifically this brings the 2 touched files in line with the config link at /packages/create-cloudflare/templates/hello-world-durable-object/js/wrangler.toml

What this PR solves / how to test

Old links are broken/not as good.

Didn't open an issue

Author has addressed the following

@Frederik-Baetens Frederik-Baetens requested review from a team as code owners April 22, 2024 22:57
Copy link

changeset-bot bot commented Apr 22, 2024

⚠️ No Changeset found

Latest commit: 77e1b56

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 22, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9374403869/npm-package-wrangler-5686

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5686/npm-package-wrangler-5686

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9374403869/npm-package-wrangler-5686 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9374403869/npm-package-create-cloudflare-5686 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9374403869/npm-package-cloudflare-kv-asset-handler-5686
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9374403869/npm-package-miniflare-5686
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9374403869/npm-package-cloudflare-pages-shared-5686
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9374403869/npm-package-cloudflare-vitest-pool-workers-5686

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.59.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240524.2
workerd 1.20240524.0 1.20240524.0
workerd --version 1.20240524.0 2024-05-24

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin petebacondarwin self-assigned this Jun 4, 2024
This brings it in line with the wrangler.toml defined in most places.

Specifically this brings the 2 touched files in line with the config
link at /packages/create-cloudflare/templates/hello-world-durable-object/js/wrangler.toml
@petebacondarwin petebacondarwin force-pushed the fbaetens/fix_do_migration_docs_link branch from 36db360 to 77e1b56 Compare June 4, 2024 21:21
@petebacondarwin petebacondarwin merged commit e640ed9 into cloudflare:main Jun 5, 2024
43 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants