-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup: Remove builtin-wasm-modules from autogates passed to workerd #5823
Conversation
The builtin-wasm-modules autogate is no longer required.
|
@dom96 since this PR was on a fork, the workflows won't run automatically I just cloned the branch and pushed to a new draft PR to trigger them but it seems there are lint errors – would you mind fixing please then we can get this merged |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9400975944/npm-package-wrangler-5823 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5823/npm-package-wrangler-5823 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9400975944/npm-package-wrangler-5823 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9400975944/npm-package-create-cloudflare-5823 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9400975944/npm-package-cloudflare-kv-asset-handler-5823 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9400975944/npm-package-miniflare-5823 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9400975944/npm-package-cloudflare-pages-shared-5823 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9400975944/npm-package-cloudflare-vitest-pool-workers-5823 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
@RamIdeas looks like you were able to resolve them, thank you! |
The builtin-wasm-modules autogate is no longer required.
What this PR solves / how to test
Doesn't fix anything. Just a cleanup.
Author has addressed the following