Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Remove builtin-wasm-modules from autogates passed to workerd #5823

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

dom96
Copy link
Contributor

@dom96 dom96 commented May 14, 2024

The builtin-wasm-modules autogate is no longer required.

What this PR solves / how to test

Doesn't fix anything. Just a cleanup.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because: cleanup
  • Public documentation

The builtin-wasm-modules autogate is no longer required.
@dom96 dom96 requested a review from a team as a code owner May 14, 2024 15:10
Copy link

changeset-bot bot commented May 14, 2024

⚠️ No Changeset found

Latest commit: dd01f2c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@RamIdeas
Copy link
Contributor

RamIdeas commented Jun 5, 2024

@dom96 since this PR was on a fork, the workflows won't run automatically

I just cloned the branch and pushed to a new draft PR to trigger them but it seems there are lint errors – would you mind fixing please then we can get this merged

Copy link
Contributor

github-actions bot commented Jun 6, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9400975944/npm-package-wrangler-5823

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5823/npm-package-wrangler-5823

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9400975944/npm-package-wrangler-5823 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9400975944/npm-package-create-cloudflare-5823 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9400975944/npm-package-cloudflare-kv-asset-handler-5823
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9400975944/npm-package-miniflare-5823
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9400975944/npm-package-cloudflare-pages-shared-5823
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9400975944/npm-package-cloudflare-vitest-pool-workers-5823

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.59.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240524.2
workerd 1.20240524.0 1.20240524.0
workerd --version 1.20240524.0 2024-05-24

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@RamIdeas RamIdeas removed the e2e Run e2e tests on a PR label Jun 6, 2024
@RamIdeas RamIdeas added the e2e Run e2e tests on a PR label Jun 6, 2024
@RamIdeas RamIdeas merged commit cd8e8ae into cloudflare:main Jun 6, 2024
46 of 52 checks passed
@dom96
Copy link
Contributor Author

dom96 commented Jun 7, 2024

@RamIdeas looks like you were able to resolve them, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants