Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --x-dev-env for Pages #6097

Merged
merged 14 commits into from
Jul 29, 2024
Merged

Support --x-dev-env for Pages #6097

merged 14 commits into from
Jul 29, 2024

Conversation

RamIdeas
Copy link
Contributor

@RamIdeas RamIdeas commented Jun 19, 2024

What this PR solves / how to test

Fixes DEVX-1296

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: experimental flag

Copy link

changeset-bot bot commented Jun 19, 2024

🦋 Changeset detected

Latest commit: b5ff4c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@RamIdeas RamIdeas added analytics engine Workers Analytics Engine e2e Run e2e tests on a PR and removed analytics engine Workers Analytics Engine labels Jun 19, 2024
@RamIdeas RamIdeas force-pushed the pages-dev-env branch 3 times, most recently from 31fa3a2 to 40fa56c Compare June 19, 2024 21:29
Copy link
Contributor

github-actions bot commented Jun 19, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10144204079/npm-package-wrangler-6097

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6097/npm-package-wrangler-6097

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10144204079/npm-package-wrangler-6097 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10144204079/npm-package-create-cloudflare-6097 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10144204079/npm-package-cloudflare-kv-asset-handler-6097
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10144204079/npm-package-miniflare-6097
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10144204079/npm-package-cloudflare-pages-shared-6097
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10144204079/npm-package-cloudflare-vitest-pool-workers-6097

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.67.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240718.1
workerd 1.20240718.0 1.20240718.0
workerd --version 1.20240718.0 2024-07-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@RamIdeas RamIdeas changed the base branch from main to config-controller June 19, 2024 21:33
packages/wrangler/src/pages/dev.ts Show resolved Hide resolved
packages/wrangler/src/pages/dev.ts Outdated Show resolved Hide resolved
packages/wrangler/src/pages/dev.ts Outdated Show resolved Hide resolved
@RamIdeas RamIdeas changed the title Pages dev env Support --x-dev-env for Pages Jun 19, 2024
Base automatically changed from config-controller to main June 20, 2024 13:48
@RamIdeas RamIdeas requested a review from penalosa June 27, 2024 18:37
@RamIdeas RamIdeas marked this pull request as ready for review June 27, 2024 18:39
@RamIdeas RamIdeas requested review from a team as code owners June 27, 2024 18:39
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few nits.

packages/wrangler/e2e/helpers/fetch-text.ts Outdated Show resolved Hide resolved
packages/wrangler/e2e/pages-dev.test.ts Outdated Show resolved Hide resolved
packages/wrangler/e2e/pages-dev.test.ts Show resolved Hide resolved
packages/wrangler/src/dev/start-server.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good. There are some flakes, perhaps?

@RamIdeas RamIdeas changed the base branch from main to fixtures-x-dev-env July 26, 2024 14:54
Base automatically changed from fixtures-x-dev-env to main July 29, 2024 10:52
@RamIdeas RamIdeas merged commit 64f34e8 into main Jul 29, 2024
20 checks passed
@RamIdeas RamIdeas deleted the pages-dev-env branch July 29, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants