-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version followups - fix rollback, version view improvements #6118
Conversation
🦋 Changeset detectedLatest commit: 09346b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9614225897/npm-package-wrangler-6118 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6118/npm-package-wrangler-6118 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9614225897/npm-package-wrangler-6118 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9614225897/npm-package-create-cloudflare-6118 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9614225897/npm-package-cloudflare-kv-asset-handler-6118 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9614225897/npm-package-miniflare-6118 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9614225897/npm-package-cloudflare-pages-shared-6118 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9614225897/npm-package-cloudflare-vitest-pool-workers-6118 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
31da3eb
to
fbf7d4e
Compare
fbf7d4e
to
09346b8
Compare
startMessage: `Performing rollback`, | ||
endMessage: "", | ||
}); | ||
logger.log("Performing rollback..."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not a great experience. It breaks the layout of the output.
Before:
? Are you sure you want to deploy this Worker Version to 100% of traffic?
🤖 Using fallback value in non-interactive context: yes
├ Performing rollback
│
After:
? Are you sure you want to deploy this Worker Version to 100% of traffic?
🤖 Using fallback value in non-interactive context: yes
Performing rollback
│
Fixes versions e2e tests that started failing after we merged ##6118
Fixes versions e2e tests that started failing after we merged ##6118
What this PR solves / how to test
Fixes rollback in interactive mode, improves the
versions view
command and small message changes to secret put/delete/bulk.Author has addressed the following